Bug: Add missing nil argument to vc-jj--process-lines call#292
Merged
Conversation
Before this change, the first argument to `vc-jj--process-lines` was `"log"`. This seems wrong. The signature of the function is: `(defun vc-jj--process-lines (file-or-list &rest args))` The docstring says: > FILE-OR-LIST may be nil or non-nil. When non-nil, it should be a file or a list of files. "log" clearly is not a file or list of files. It's the jj subcommand we aim to run. Running the following in my repository: `(vc-jj--process-lines "log" "--no-graph" "-r" "@-" "-T" "change_id" "-n" "1")` returns `nil` ...whereas running the following: `(vc-jj--process-lines nil "log" "--no-graph" "-r" "@-" "-T" "change_id" "-n" "1")` returns the actual revision
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the first argument to
vc-jj--process-lineswas"log". This seems wrong.The signature of the function is:
(defun vc-jj--process-lines (file-or-list &rest args))The docstring says:
"log" clearly is not a file or list of files. It's the jj subcommand we aim to run.
Running the following in my repository:
(vc-jj--process-lines "log" "--no-graph" "-r" "@-" "-T" "change_id" "-n" "1")returnsnil...whereas running the following:
(vc-jj--process-lines nil "log" "--no-graph" "-r" "@-" "-T" "change_id" "-n" "1")returns the actual revision