Add CSE#2716
Open
nikita-volkov wants to merge 4 commits into
Open
Conversation
Comment on lines
+53
to
+61
| cse :: forall a. Ord a => Expr Void a -> Expr Void a | ||
| cse expr = go freshNames candidates expr | ||
| where | ||
| -- Count occurrences of each subexpression using cosmosOf to traverse all levels | ||
| counts :: Map (Expr Void a) Int | ||
| counts = Map.fromListWith (+) | ||
| [ (sub, 1) | ||
| | sub <- Lens.foldMapOf (Lens.cosmosOf subExpressions) (:[]) expr | ||
| ] |
Collaborator
There was a problem hiding this comment.
I think this will not correctly handle the following case:
let x = 1
let y = nonTrivialExpressionOf x
let x = 2
in nonTrivialExpressionOf x
If I understand correctly, the logic would count both occurrences of nonTrivialExpressionOf x as the same sub-expression even though x would differ in both cases.
My intuition here is that this would require explicit recursion over the syntax tree to correctly handle this.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2715
(LLM-generated and edited by me).