Skip to content

feat: [DHIS2-21266] Integrate react Markdown lib#4621

Open
simonadomnisoru wants to merge 19 commits into
masterfrom
DHIS2-21266-from-fork
Open

feat: [DHIS2-21266] Integrate react Markdown lib#4621
simonadomnisoru wants to merge 19 commits into
masterfrom
DHIS2-21266-from-fork

Conversation

@simonadomnisoru

@simonadomnisoru simonadomnisoru commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

DHIS2-21266

The work in the PR belongs to @fernandogmz and was implemented in #4595.

I am using this branch as a workaround to run CI checks, since CI currently doesn't trigger on external fork PRs. We are aware that we need a better process to accommodate and encourage external contributions. Following an internal discussion, we've decided to stick with this workaround for now rather than investing time into optimizing the process.

dhis2-bot and others added 11 commits June 18, 2026 14:46
# [106.5.0](v106.4.5...v106.5.0) (2026-06-17)

### Features

* [DHIS2-16610] Add support for configurable terminology labels  ([#4609](#4609)) ([b23386a](b23386a))
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.29.6 to 7.29.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.29.7/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-version: 7.29.7
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…4614)

Bumps [@dhis2/cypress-plugins](https://github.com/dhis2/cli-utils-cypress) from 10.1.0 to 10.1.2.
- [Release notes](https://github.com/dhis2/cli-utils-cypress/releases)
- [Changelog](https://github.com/dhis2/cli-utils-cypress/blob/master/CHANGELOG.md)
- [Commits](dhis2/cli-utils-cypress@v10.1.0...v10.1.2)

---
updated-dependencies:
- dependency-name: "@dhis2/cypress-plugins"
  dependency-version: 10.1.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dotenv](https://github.com/motdotla/dotenv) from 16.6.1 to 17.4.2.
- [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md)
- [Commits](motdotla/dotenv@v16.6.1...v17.4.2)

---
updated-dependencies:
- dependency-name: dotenv
  dependency-version: 17.4.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.28.6 to 7.29.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.29.7/eslint/babel-eslint-parser)

---
updated-dependencies:
- dependency-name: "@babel/eslint-parser"
  dependency-version: 7.29.7
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Integrate react markdown library to support standard md elements
- Apply corresponding legend sets for rule actions where apply
- Create Markdown e2e testing for markdown integration
* Folder structure
* Update cypress tests
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

@henrikmv henrikmv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @fernandogmz, and thank you @simonadomnisoru for creating this PR as a workaround for the blocking security rule on our CI checks.

I have left a few comments. Thank you!

Comment thread src/core_modules/capture-core/rules/RuleEngine/helpers/rulesEffectsProcessor.ts Outdated
Comment thread src/core_modules/capture-core/rules/RuleEngine/helpers/rulesEffectsProcessor.ts Outdated
@fernandogmz

Copy link
Copy Markdown

@henrikmv @simonadomnisoru I have pushed a new commit on the fork branch, please update this one as needed.

fernandogmz and others added 2 commits June 29, 2026 09:45
- Wrap MarkdownWrapper component with React.memo
- Remove unused priority parameters at rulesEffectsProcessor

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread src/core_modules/capture-core/rules/RuleEngine/helpers/rulesEffectsProcessor.ts Outdated
devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread src/core_modules/capture-core/components/WidgetFeedback/WidgetFeedback.types.ts Outdated
Comment thread src/core_modules/capture-core/components/WidgetFeedback/WidgetFeedback.types.ts Outdated

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

@henrikmv henrikmv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants