feat: show only Explore and About pages if user does not have import access#133
Draft
jenniferarnesen wants to merge 2 commits into
Draft
feat: show only Explore and About pages if user does not have import access#133jenniferarnesen wants to merge 2 commits into
jenniferarnesen wants to merge 2 commits into
Conversation
Contributor
|
🚀 Deployed on https://pr-133.climate-app.netlify.dhis2.org |
|
This is the right authority to use. There are a couple of nuances worth keeping in mind for the feature.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



In order to not provide disruption and force implementations to set up new roles, instead of enforcing an app-specific authority, for now just check whether the user has access to import data.
User without import access only sees Home and Explore tabs:

User without import access trying to directly access by url:

User with import access gets the normal options:

https://dhis2.atlassian.net/browse/CLIM-89