Skip to content

feat: show only Explore and About pages if user does not have import access#133

Draft
jenniferarnesen wants to merge 2 commits into
mainfrom
fix/restrict-import-page-access
Draft

feat: show only Explore and About pages if user does not have import access#133
jenniferarnesen wants to merge 2 commits into
mainfrom
fix/restrict-import-page-access

Conversation

@jenniferarnesen

@jenniferarnesen jenniferarnesen commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

In order to not provide disruption and force implementations to set up new roles, instead of enforcing an app-specific authority, for now just check whether the user has access to import data.

User without import access only sees Home and Explore tabs:
image

User without import access trying to directly access by url:
image

User with import access gets the normal options:
image

https://dhis2.atlassian.net/browse/CLIM-89

@dhis2-bot

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://pr-133.climate-app.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify July 2, 2026 16:44 Inactive
@netroms

netroms commented Jul 3, 2026

Copy link
Copy Markdown

This is the right authority to use. There are a couple of nuances worth keeping in mind for the feature.

  • If the user has ALL authority, the user is super admin and also have full access, including F_DATAVALUE_ADD.
  • Even if the user has F_DATAVALUE_ADD, it's not guaranteed that they have access to what they are trying to import. Things as data set access, cat combo and org unit ACL also decides in the end if they can. But to just "gate" the import feature, the authority check is the right way to go about it.

@jenniferarnesen jenniferarnesen marked this pull request as draft July 3, 2026 10:52
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants