feat: [ANDROAPP-7605] Add granular sync use-case for datasets and data values#4957
Merged
Conversation
andresmr
reviewed
Jul 3, 2026
| .blockingUpload() | ||
| } | ||
|
|
||
| // TODO: The sdk does not provide methods to download data values for a given dataset |
Collaborator
There was a problem hiding this comment.
is there anything to do here or could this be removed?
Collaborator
Author
There was a problem hiding this comment.
The SDK lacks these methods, but they are important. I'll be opening a ticket in the sdk to add these methods so we can use them.
| } | ||
|
|
||
| // TODO: The sdk does not provide methods to download data values for a given dataset | ||
| override suspend fun downloadDataSet(dataSetUid: DataSetUid) { |
Collaborator
There was a problem hiding this comment.
why do you create this method if is empty? is it being used?
ferdyrod
approved these changes
Jul 8, 2026
Balcan
force-pushed
the
ANDROAPP-7605-syncdataset
branch
from
e6b2ae0 to
523072d
Compare
|
andresmr
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link the JIRA issue.
Please provide a clear definition of the problem and explain your solution.