Skip to content

Commit da9853a

Browse files
committed
[ANDROSDK-2181] use internal suspend methods instead of blockinggets
1 parent d68c0ee commit da9853a

27 files changed

Lines changed: 56 additions & 36 deletions

core/src/main/java/org/hisp/dhis/android/core/analytics/aggregated/internal/AnalyticsServiceMetadataHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ internal class AnalyticsServiceMetadataHelper(
149149
?: throw AnalyticsException.InvalidIndicator(item.uid)
150150

151151
is DimensionItem.DataItem.ProgramIndicatorItem ->
152-
programIndicatorRepository.withAnalyticsPeriodBoundaries().uid(item.uid).blockingGet()
152+
programIndicatorRepository.withAnalyticsPeriodBoundaries().uid(item.uid).getInternal()
153153
?.let { programIndicator -> MetadataItem.ProgramIndicatorItem(programIndicator) }
154154
?: throw AnalyticsException.InvalidProgramIndicator(item.uid)
155155

core/src/main/java/org/hisp/dhis/android/core/analytics/aggregated/internal/evaluator/indicatorengine/dataitem/IndicatorDataItem.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ internal interface IndicatorDataItem : ExpressionItem {
128128
val programIndicator = visitor.indicatorContext!!.programIndicatorRepository
129129
.withAnalyticsPeriodBoundaries()
130130
.uid(dataItem.uid)
131-
.blockingGet()
131+
.getInternal()
132132
?: throw AnalyticsException.InvalidProgramIndicator(dataItem.uid)
133133

134134
dataItem.uid to MetadataItem.ProgramIndicatorItem(programIndicator)

core/src/main/java/org/hisp/dhis/android/core/analytics/linelist/EventLineListServiceImpl.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ internal class EventLineListServiceImpl(
6868
@Suppress("LongMethod", "ComplexMethod")
6969
private suspend fun evaluateEvents(params: EventLineListParams): List<LineListResponse> {
7070
val events = getEvents(params)
71-
val programStage = programStageRepository.uid(params.programStage).blockingGet()
71+
val programStage = programStageRepository.uid(params.programStage).getInternal()
7272

7373
val metadataMap = getMetadataMap(
7474
params.dataElements,
@@ -80,15 +80,15 @@ internal class EventLineListServiceImpl(
8080
dataValueRepository
8181
.byEvent().`in`(events.map { it.uid() })
8282
.byDataElement().`in`(params.dataElements.map { it.uid })
83-
.blockingGet()
83+
.getInternal()
8484
} else {
8585
listOf()
8686
}
8787

8888
return events.mapNotNull {
8989
(it.eventDate() ?: it.dueDate())?.let { referenceDate ->
9090
val periodType = programStage?.periodType() ?: PeriodType.Daily
91-
val eventPeriod = periodHelper.blockingGetPeriodForPeriodTypeAndDate(periodType, referenceDate)
91+
val eventPeriod = periodHelper.getPeriodForPeriodTypeAndDateInternal(periodType, referenceDate)
9292

9393
val eventDataValues = params.dataElements.map { de ->
9494
val dv = dataElementValues.find { dv -> dv.event() == it.uid() && dv.dataElement() == de.uid }
@@ -164,7 +164,7 @@ internal class EventLineListServiceImpl(
164164
}
165165

166166
return if (params.eventDates.isNullOrEmpty()) {
167-
repoBuilder.blockingGet()
167+
repoBuilder.getInternal()
168168
} else {
169169
params.eventDates.flatMap { filter ->
170170
var innerBuilder = repoBuilder
@@ -174,7 +174,7 @@ internal class EventLineListServiceImpl(
174174
dateFilterPeriodHelper.getEndDate(filter)?.let {
175175
innerBuilder = innerBuilder.byEventDate().beforeOrEqual(it)
176176
}
177-
innerBuilder.blockingGet()
177+
innerBuilder.getInternal()
178178
}
179179
}
180180
}

core/src/main/java/org/hisp/dhis/android/core/arch/repositories/object/internal/ReadOnlyObjectRepositoryImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ abstract class ReadOnlyObjectRepositoryImpl<M, R : ReadOnlyObjectRepository<M>>
6363
return runBlocking { getInternal() }
6464
}
6565

66-
protected suspend fun getInternal(): M? {
66+
internal suspend fun getInternal(): M? {
6767
return ChildrenAppenderExecutor.appendInObject(
6868
blockingGetWithoutChildren(),
6969
childrenAppenderGetter,

core/src/main/java/org/hisp/dhis/android/core/arch/repositories/object/internal/ReadOnlyWithTransformerObjectRepositoryImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ internal constructor(
7373
return runBlocking { getInternal() }
7474
}
7575

76-
private suspend fun getInternal(): T? {
76+
internal suspend fun getInternal(): T? {
7777
val item = ChildrenAppenderExecutor.appendInObject(
7878
getWithoutChildrenInternal(),
7979
childrenAppenders,

core/src/main/java/org/hisp/dhis/android/core/dataset/DataSetCompleteRegistrationObjectRepository.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class DataSetCompleteRegistrationObjectRepository internal constructor(
8282
private suspend fun setInternal() {
8383
val dataSetCompleteRegistration = getWithoutChildrenInternal()
8484
if (dataSetCompleteRegistration == null) {
85-
val username = credentialsRepository.blockingGet()!!.username()
85+
val username = credentialsRepository.getInternal()!!.username()
8686
dataSetCompleteRegistrationStore.insert(
8787
DataSetCompleteRegistration.builder()
8888
.period(period)

core/src/main/java/org/hisp/dhis/android/core/enrollment/internal/EnrollmentServiceImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ internal class EnrollmentServiceImpl(
8383
trackedEntityInstanceUid: String,
8484
programUid: String,
8585
): EnrollmentAccess {
86-
val program = programRepository.uid(programUid).blockingGet() ?: return EnrollmentAccess.NO_ACCESS
86+
val program = programRepository.uid(programUid).getInternal() ?: return EnrollmentAccess.NO_ACCESS
8787

8888
val dataAccess =
8989
if (program.access()?.data()?.write() == true) {

core/src/main/java/org/hisp/dhis/android/core/event/internal/EventQueryBundleInternalFactory.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ internal class EventQueryBundleInternalFactory(
7171
eventFilterCollectionRepository
7272
.byUid().`in`(it)
7373
.withEventDataFilters()
74-
.blockingGet()
74+
.getInternal()
7575
}
7676

7777
val builder = EventQueryBundle.builder()

core/src/main/java/org/hisp/dhis/android/core/indicator/datasetindicatorengine/DataSetIndicatorEngineImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ internal class DataSetIndicatorEngineImpl(
8585
orgUnitUid: String,
8686
attributeOptionComboUid: String,
8787
): Double {
88-
val indicator = indicatorRepository.uid(indicatorUid).blockingGet()
89-
val indicatorType = indicatorTypeRepository.uid(indicator?.indicatorType()?.uid()).blockingGet()
88+
val indicator = indicatorRepository.uid(indicatorUid).getInternal()
89+
val indicatorType = indicatorTypeRepository.uid(indicator?.indicatorType()?.uid()).getInternal()
9090

9191
return if (indicator != null && indicatorType != null) {
9292
val context = ExpressionServiceContext(

core/src/main/java/org/hisp/dhis/android/core/period/internal/PeriodHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ class PeriodHelper internal constructor(
100100
return runBlocking { getPeriodForPeriodTypeAndDateInternal(periodType, date, periodOffset) }
101101
}
102102

103-
private suspend fun getPeriodForPeriodTypeAndDateInternal(
103+
internal suspend fun getPeriodForPeriodTypeAndDateInternal(
104104
periodType: PeriodType,
105105
date: Date,
106106
periodOffset: Int = 0,

0 commit comments

Comments
 (0)