chore: [ANDROSDK-2323] migrate enrollment domain models to kotlin#2639
Merged
Conversation
fix tests and update api dump
|
vgarciabnz
approved these changes
Jun 17, 2026
| } | ||
|
|
||
| @JvmStatic | ||
| fun create( |
Member
There was a problem hiding this comment.
Just as a comment, there is a function called @JvmOverloads that gets the same behavior by using the default kotlin parameters, so we have just one function with the default value to null. It would be seen as two different functions from the java world.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Migrates the enrollment domain models (batch 10) from Java AutoValue classes to Kotlin data classes using the
@ModelBuilderKSP annotation:EnrollmentandEnrollmentCreateProjection. The public API and persistence behavior are kept unchanged, and the deprecated in-memorycoordinatehandling is dropped in favour ofgeometry.As part of the migration,
EnrollmentInternalAccessoris removed: theevents/relationshipsproperties becomeinternalon the model and the call sites use them directly.EnrollmentConverteris ported to Kotlin to access those internal members, which required widening the abstract methods of the SMSConverterbase (and its subclasses) toprotectedso a Kotlin subclass can override them. The API dump was regenerated accordingly.Related task: ANDROSDK-2323