Skip to content

chore: [ANDROSDK-2323] migrate enrollment domain models to kotlin#2639

Merged
vgarciabnz merged 6 commits into
developfrom
ANDROSDK-2323
Jun 17, 2026
Merged

chore: [ANDROSDK-2323] migrate enrollment domain models to kotlin#2639
vgarciabnz merged 6 commits into
developfrom
ANDROSDK-2323

Conversation

@taridepaco

@taridepaco taridepaco commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Migrates the enrollment domain models (batch 10) from Java AutoValue classes to Kotlin data classes using the @ModelBuilder KSP annotation: Enrollment and EnrollmentCreateProjection. The public API and persistence behavior are kept unchanged, and the deprecated in-memory coordinate handling is dropped in favour of geometry.

As part of the migration, EnrollmentInternalAccessor is removed: the events/relationships properties become internal on the model and the call sites use them directly. EnrollmentConverter is ported to Kotlin to access those internal members, which required widening the abstract methods of the SMS Converter base (and its subclasses) to protected so a Kotlin subclass can override them. The API dump was regenerated accordingly.

Related task: ANDROSDK-2323

@sonarqubecloud

sonarqubecloud Bot commented Jun 16, 2026

Copy link
Copy Markdown

}

@JvmStatic
fun create(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a comment, there is a function called @JvmOverloads that gets the same behavior by using the default kotlin parameters, so we have just one function with the default value to null. It would be seen as two different functions from the java world.

@vgarciabnz vgarciabnz merged commit 05f1541 into develop Jun 17, 2026
11 checks passed
@vgarciabnz vgarciabnz deleted the ANDROSDK-2323 branch June 17, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants