chore: [ANDROSDK-2330] migrate map layer domain models to kotlin#2645
Merged
Conversation
vgarciabnz
reviewed
Jun 25, 2026
| class Builder : MapLayerBuilder() | ||
|
|
||
| companion object { | ||
| const val IMAGERY_PROVIDERS = "imageryProviders" |
Member
There was a problem hiding this comment.
I don't think this property was intentionally public in the model class. It seems it is only used for the childrenAppender identification, so it could be moved to the companion object in the collectionRepository as the rest of children appenders
vgarciabnz
previously approved these changes
Jun 25, 2026
|
vgarciabnz
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the map layer domain models (
MapLayer,MapLayerImageryProviderandMapLayerImageryProviderArea) from Java AutoValue classes to Kotlin data classes using the@ModelBuilderannotation, as part of batch 12 of the domain model Kotlin migration.As part of the migration the
MapLayer.externalproperty is tightened to non-null to match its API contract. This adds a migration in181.sqlthat recreates theMapLayertable withexternal INTEGER NOT NULL(dropping rows where it was null) and adaptsMapLayerDBaccordingly.Related task: ANDROSDK-2330