chore: [ANDROSDK-2332] migrate maintenance domain models to Kotlin#2647
Merged
Conversation
|
vgarciabnz
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Migrates the maintenance domain models
ForeignKeyViolationandD2Errorfrom Java AutoValue classes to Kotlin data classes built with the@ModelBuilderKSP annotation. Java-style accessor methods, thebuilder()/toBuilder()API andD2Error.isOfflineare all preserved, so existing call sites and the public API surface are unchanged.D2Errorexposed two limitations in the@ModelBuilderprocessor that are also fixed here: typealiased field types (it extendsException) were rendered as[typealias Exception]and produced uncompilable builders, and computed properties (such as the derivedisOffline) were being treated as builder fields. The processor now renders typealiases correctly and only treats primary-constructor parameters as model fields. The two conditional defaults from the oldD2Error.build()(errorCodeandcreated) move into thebuilder()factory.Related task: ANDROSDK-2332