chore: [ANDROSDK-2339] migrate RepositoryScope to Kotlin#2656
Merged
Conversation
|
andresmr
approved these changes
Jul 2, 2026
vgarciabnz
reviewed
Jul 2, 2026
| data class RepositoryScope internal constructor( | ||
| val filters: List<RepositoryScopeFilterItem>, | ||
| val complexFilters: List<RepositoryScopeComplexFilterItem>, | ||
| internal val orderBy: List<RepositoryScopeOrderByItem>, |
Member
There was a problem hiding this comment.
Why are these two properties internal? They were public before.
Collaborator
Author
There was a problem hiding this comment.
They were exposing an internal classes (RepositoryScopeComplexFilterItem and RepositoryScopeOrderByItem)
vgarciabnz
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
RepositoryScopefrom a Java AutoValue class to a Kotlin data class using the@ModelBuilderannotation (domain models batch 20). It also adjustsModelBuilderProcessorso that the builder backing properties generated forinternalfields useprivatevisibility instead ofprotected: this prevents an internal type from leaking through a public builder while avoiding name shadowing inside callers'builder().apply { }blocks.It additionally fixes a null pointer bug in program stage section handling by moving the logic that assigns the parent program stage UID to the network layer instead of the handler.
Related task: ANDROSDK-2339