chore: [ANDROSDK-2241] update koin to 4.2.2 and migrate to the compiler plugin#2659
Merged
Conversation
|
vgarciabnz
approved these changes
Jul 6, 2026
vgarciabnz
left a comment
Member
There was a problem hiding this comment.
I really don't understand why the WipeDIModule needs the declaration of the rest of the modules, but it fails if not added. We can check when @taridepaco is back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Updates Koin from 3.5.6 to 4.2.2 and replaces the KSP-based Koin Annotations processor with the new Koin Compiler Plugin (1.0.1), which requires Kotlin 2.3.20. This unblocks KSP2, so the
ksp.useKSP2=falseworkaround is removed and KSP is updated to 2.3.9 (now only used by Room and the internal DAO processor). Module registration inD2DIComponentFactorymoves from the generatedXxxDIModule().moduleextensions to the plugin's typedmodules(KClass...)API. The last classes registered through the classic DSL (javaDIClasses) are migrated to Kotlin and annotated with@Singleton, so the whole graph is now annotation-based.With the DSL module gone, the plugin's compile-time dependency verification (
compileSafety) is kept enabled for the main compilation. This required declaring explicitincludesin the Network, Persistence and Wipe DI modules (real cross-module dependencies that the checker cannot resolve reliably otherwise), disablingstrictSafety, and turning the checker off for test compilations, where it runs against a partial definition index and reports false positives. If spuriousKOIN-D001errors ever show up in CI, the fix is either adding the correspondingincludeor disablingcompileSafetyuntil the plugin matures.Note: this branch is stacked on top of #2658 (ANDROSDK-2340); the diff will narrow down to the Koin changes once that PR is merged.
Related task: ANDROSDK-2241