chore: [ANDROSDK-2275] Adds plurals terminology to Program, ProgramStage and TrackedEntityType#2661
chore: [ANDROSDK-2275] Adds plurals terminology to Program, ProgramStage and TrackedEntityType#2661ferdyrod wants to merge 2 commits into
Conversation
|
|
|
||
| package org.hisp.dhis.android.network.program | ||
|
|
||
| import android.system.Os.access |
There was a problem hiding this comment.
This is not intentional, is it? I don't know why it was not detected by the checks...
There was a problem hiding this comment.
Don't know why this was added, will remove it
| featureType(featureType?.let { FeatureType.valueOf(it) }) | ||
| accessLevel(accessLevel?.let { AccessLevel.valueOf(accessLevel) }) | ||
| displayEnrollmentLabel(displayEnrollmentLabel ?: enrollmentLabel) | ||
| displayEnrollmentsLabel(displayEnrollmentsLabel ?: enrollmentLabel) |
There was a problem hiding this comment.
I am not sure we should default to the singular value here, at least not in the SDK. It is important to tell the app that the plural translation is not defined so the app can decide what to to: the app can default to the singular translation or follow another approach.
There was a problem hiding this comment.
yes, it makes sense to me.
There was a problem hiding this comment.
I agree, I'll change it
3 participants
Adds custom plurals terminology to Program object with
displayEnrollmentsLabel,displayProgramStagesLabel,displayEventsLabelnow are available. ToProgramStageobjectdisplayEventsLabelis now available and theTrackedEntityTypeobjectdisplayTrackedEntityTypesLabelis now available.Related to ANDROSDK-2275