feature: [ANDROSDK-2345] build logout url#2662
Open
andresmr wants to merge 1 commit into
Open
Conversation
|
vgarciabnz
reviewed
Jul 10, 2026
|
|
||
| override fun buildLogoutUrl(serverUrl: String, state: String): String { | ||
| return "$serverUrl/dhis-web-commons-security/logout.action" + | ||
| "?redirect_uri=${OAuth2Config.DEFAULT_REDIRECT_URI}" + |
Member
There was a problem hiding this comment.
The OAuth2Config class has a redirectUri property. Should we take this in the first place and, if it doesn't exist, default to the default one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a logout URL builder to the OAuth2 handler so apps can unregister the device after an offline login setup.
d2.userModule().oauth2Handler().buildLogoutUrl(serverUrl)generates a state, persists it, and delegates to the network handler to build$serverUrl/dhis-web-commons-security/logout.action?redirect_uri=$REDIRECT_URI&state=$state, so the logout redirect can be correlated with the request. Unit tests cover bothOAuth2HandlerImplandOAuth2NetworkHandlerImpl.Related task: ANDROSDK-2345