Skip to content

chore: refresh security translations across 31 languages + AI placeholders [DHIS2-19912] - #23073

Merged
netroms merged 2 commits into
masterfrom
chore_align_sec_related_translations
May 22, 2026
Merged

chore: refresh security translations across 31 languages + AI placeholders [DHIS2-19912]#23073
netroms merged 2 commits into
masterfrom
chore_align_sec_related_translations

Conversation

@netroms

@netroms netroms commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Related: DHIS2-19912

Summary

Two-step cleanup of "English-as-translation" security strings:

Commit 1 — 85ca17e136d: Remove 27 security keys across 31 languages (621 lines deleted). Keys covered: verify_email_*, email_2fa_*, OIDC/login (login_with_*, oidc_login_failed, sign_in_with_openID, login_using_two_factor_authentication, two_factor_authentication_code, mandatory_parameter_missing, password_lowercase_validation), impersonation (impersonate_user, F_IMPERSONATE_USER, F_PREVIOUS_IMPERSONATOR_AUTHORITY), authority labels (F_USER_VIEW, F_USER_VIEW_WITHIN_MANAGED_GROUP, F_VISUALIZATION_EXTERNAL, F_EVENT_VISUALIZATION_EXTERNAL). Real translations were preserved (script only removed lines where value byte-equals English source).

Commit 2 — 1a99d828d71: Add AI-generated placeholder translations for 20 widely-spoken languages so end-users don't see English in security flows while translators do their work (506 lines added). Each block headed with a comment marking it AI-assisted and pending review.

Languages with AI placeholders: ar, ar_IQ, bn, cs, da, es, es_419, hi_IN, id, nb, ne, nl, pt, pt_BR, ro, ru, sv, uk, ur, zh_CN.

Lower-resource languages (ckb, km, my, or, prs, ps, si, tet, tg, uz_UZ_Cyrl, uz_UZ_Latn) intentionally not auto-translated — those need native-speaker review.

Transifex side

Both the deletions and the AI placeholders were pushed to Transifex via tx push -t -f. Verified round-trip for ru, es, pt, zh_CN (local-after-push == Transifex-pulled).

Follow-ups

  • Translator follow-up: post a Transifex Announcement asking translators to review the AI placeholders. Russian most urgent (QA-reported).
  • Cherry-pick deletions (commit 1) to 2.40-2.43; AI translations (commit 2) optional per branch
  • .tx/config points to a non-existent resource ID (r:i18n-global-properties rather than r:master--i18n-global-properties); the CLI compensates via branch heuristics, but the config should be fixed in a separate PR
  • The 27 strings need translator review in Transifex once announced

AI Assisted

@sonarqubecloud

Copy link
Copy Markdown

@netroms
netroms force-pushed the chore_align_sec_related_translations branch from b09f5b8 to 85ca17e Compare May 11, 2026 15:28
@netroms netroms changed the title chore: force security related translations to refresh chore: refresh fake security translations across 31 languages [DHIS2-19912] May 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@netroms
netroms marked this pull request as ready for review May 16, 2026 16:49
@netroms netroms changed the title chore: refresh fake security translations across 31 languages [DHIS2-19912] chore: refresh security translations across 31 languages + AI placeholders [DHIS2-19912] May 20, 2026
@netroms
netroms marked this pull request as draft May 21, 2026 06:14
netroms added 2 commits May 21, 2026 17:56
Remove entries where target value was byte-identical to the English
source. 27 security-related keys cleaned across 31 languages
(verify_email, 2FA email, OIDC/login, impersonation, password validation,
authority labels). Transifex DB pushed in parallel so translators see
these as untranslated for retranslation.

Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
…912]

Add provisional AI-generated translations across 20 widely-spoken
languages for the 27 security keys cleaned in the previous commit
(verify_email, 2FA email, OIDC/login, impersonation, password validation,
authority labels). Marked in-file as "AI-assisted, pending translator
review" so future maintainers know to look for translator improvements.

Languages: ar, ar_IQ, bn, cs, da, es, es_419, hi_IN, id, nb, ne, nl, pt,
pt_BR, ro, ru, sv, uk, ur, zh_CN. Lower-resource languages (ckb, km, my,
or, prs, ps, si, tet, tg, uz_UZ_Cyrl, uz_UZ_Latn) left untranslated for
native-speaker review only.

Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
@netroms
netroms force-pushed the chore_align_sec_related_translations branch from 1a99d82 to 5e9b05a Compare May 21, 2026 09:58
@sonarqubecloud

Copy link
Copy Markdown

@Philip-Larsen-Donnelly

Copy link
Copy Markdown
Contributor

We should discuss this as it seem to break our translation process (which Claude is not aware of).

Pushing stuff to Transifex before this PR is merged means that the Transifex source of truth is currently not compatible with the master branch. The next scheduled sync will revert any source changes that have been pushed related to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants