feat: URL params to records via JSON [DHIS2-17932]#23754
Merged
Conversation
jbee
marked this pull request as ready for review
May 21, 2026 11:23
|
jbee
enabled auto-merge (squash)
May 21, 2026 11:57
vietnguyen
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Adds
UrlParamsmarker interface to put onrecordclasses that should be injected into an endpoint method. Any@Validationconstraint in therecordwill be validated before mapping the request parameters to the record. In case of validation errors aBadRequestExceptionis thrown (as it should be a "user error").To test the concept I applied it to 2 cases,
MinMaxDataElementParamsandDataValueChangelogQueryParams.Automated Testing
Existing tests got adjusted (mostly the test setup that was affected by the slightly different way of constructing params).
A new test was added for the URL parameter to JSON mapping.
As most of the actual implementation is within
json-treethe relevent code is covered with many unit-tests in the library.Manual Testing
/api/minMaxDataElements?page=2&pageSize=5&fields=min&fields=sourceand vary URL parameters/api/audits/dataValue?page=2&fields=dataElementand vary URL parameters (in particular using values that should be rejected)Documentation