fix: Fix continuous event analytics export (2.40)#23860
Merged
Conversation
* Invert skipPrograms ternary in getRegularAnalyticsTables (was returning all programs when skip list was set, filtering when not) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jason-p-pickering
changed the title
|
maikelarabori
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Fix skipPrograms filter inversion in continuous event analytics export
Fixes a bug in getRegularAnalyticsTables where the skipPrograms ternary was inverted: when a skip-program list was provided, all programs were returned unfiltered; when no skip list was set, it attempted to filter against an empty set.
Note: scope differs from the equivalent fix in 2.41+
The 2.41/2.42/2.43/master fix addressed two bugs:
Bug 2 does not exist in 2.40. The 2.40 AnalyticsTable model has separate getTableName() (live) and getTempTableName() (staging) methods, and removeUpdatedData correctly used getTableName(). The staging/live name conflation was introduced when the table model was refactored in 2.41 and the bug has existed there ever since.
Testing: Added a unit test confirming that programs listed in skipPrograms are excluded from the regular analytics table build.