Skip to content

fix: mapView should not be exported at root level#23863

Merged
vietnguyen merged 1 commit into
masterfrom
DHIS2-20266
May 12, 2026
Merged

fix: mapView should not be exported at root level#23863
vietnguyen merged 1 commit into
masterfrom
DHIS2-20266

Conversation

@vietnguyen

Copy link
Copy Markdown
Contributor

https://dhis2.atlassian.net/browse/DHIS2-20266

Issue

  • User reported that when export metadata with Map and MapView, then import again, server throw duplicate exception because MapView included at root level and also inside Map object.

Fix

  • The issue happens because MapView is both embedded object and identifiable object.
  • This PR fix the issue by remove the MapViewSchemaDiscriptor, this will exclude MapView from the root level of the metadata export.
  • This PR also remove the AbstractCrudController from MapViewController so this object can only be imported as a collection of Map object through MapController.

Test

  • Added test and existing test in MapControllerTest also passed.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants