test: Add tests covering BlobStoreService operations [DHIS2-20648]#23867
Merged
Conversation
|
david-mackessy
changed the title
david-mackessy
marked this pull request as ready for review
May 12, 2026 11:02
david-mackessy
commented
May 12, 2026
|
|
||
| @Override | ||
| public void afterAll(ExtensionContext context) { | ||
| MIN_IO_CONTAINER.stop(); |
Contributor
Author
There was a problem hiding this comment.
Testcontainers' Ryuk reaper handles teardown on JVM exit
david-mackessy
enabled auto-merge (squash)
May 12, 2026 12:21
netroms
approved these changes
May 12, 2026
jbee
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assisted 🤖
Summary
Add tests for the
BlobStoreServicebefore migration, increasing safety, confidence and success of the migration.Tests added for the different implementations we support:
These are marked as
@Tag("integration"):S3BlobStoreServiceContractTestuses the existing MinIO container for tests.Info
Multiple
TODOs added for context about issues with the current JClouds limitations which will be resolved during the migration: