fix: SQL typo in analytics export [DHIS2-21496]#23897
Merged
Merged
Conversation
luciano-fiandesio
approved these changes
May 13, 2026
|
This was referenced May 13, 2026
vietnguyen
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a typo in the SQL generated during the analytics export process, when
keyRespectMetaDataStartEndDatesInAnalyticsTableExportis enabled.It causes a SQL statement like
and dv."deleted" = falseand (aon.startdate is null or aon.startdate <= ps.startdate), where it should beand dv."deleted" = false and (aon.startdate is null or aon.startdate <= ps.startdate).Not the typo in
falseand(fixed tofalse and).The logic was encapsulated in a method so we could properly test it.