Skip to content

fix: Use authenticated user to save note [DHIS2-20208] #23901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
muilpp wants to merge 1 commit into from
Closed

fix: Use authenticated user to save note [DHIS2-20208] #23901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...is-test-integration/src/test/java/org/hisp/dhis/tracker/imports/note/NoteServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ private void assertNotes(
private Note note() {
return Note.builder()
.note(UID.generate())
.storedBy("This is the creator")
.storedBy(userDetails.getUsername())
.value("This is a note")
.build();
}
Expand Down
2 changes: 1 addition & 1 deletion dhis-2/dhis-tracker/src/main/java/org/hisp/dhis/tracker/imports/note/JdbcNoteStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private long saveNote(@Nonnull Note note, @Nonnull UserDetails user) {

MapSqlParameterSource params = new MapSqlParameterSource();
params.addValue("text", note.getValue());
params.addValue("creator", note.getStoredBy());
params.addValue("creator", user.getUsername());
params.addValue("lastUpdatedBy", user.getUid());
params.addValue("uid", note.getNote().getValue());
params.addValue("created", new Date());
Expand Down
Loading