task: Remove storedBy from tracker objects [DHIS2-21537] - #23971
Merged
Conversation
muilpp
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
muilpp
force-pushed
the
DHIS2-21537-TE-enrollments-events
branch
from
May 25, 2026 09:38
037cf84 to
e14b5b1
Compare
muilpp
marked this pull request as ready for review
May 25, 2026 10:14
ameenhere
approved these changes
May 25, 2026
ameenhere
left a comment
ameenhere
left a comment
Contributor
There was a problem hiding this comment.
Minor naming comment. Approving anyway. Hope we can get the Analytics fixes in the same branch before merging
enricocolasante
approved these changes
May 26, 2026
| eventDataValue.setDataElement(dataElement); | ||
| JsonObject dataValueJson = JsonMixed.of(dataValueResult).asObject(); | ||
| eventDataValue.setValue(dataValueJson.getString("value").string("")); | ||
| eventDataValue.setStoredBy(dataValueJson.getString("storedBy").string(null)); |
Contributor
There was a problem hiding this comment.
Do we still have storedBy in event data values? Same for single events
Contributor
Author
There was a problem hiding this comment.
I'm removing it from event data values in this other PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m removing
storedByfrom tracked entities, enrollments, and events because the same information is already available increatedByUserInfo. At the API level, Android and Frontend can usecreatedByinstead.The failing tests are in analytics, so those need to be fixed before I can merge this PR.