security backport:#148 → 2.39#24149
Closed
netroms wants to merge 1 commit into
Closed
Conversation
…tion The filter column name was concatenated raw into the generated WHERE clause in DefaultSqlViewService.getFilterQuery, mirroring the same shape that getCriteriaSqlClause already handles correctly via statementBuilder.columnQuote(). Two independent reports demonstrate the missed sink is exploitable for arbitrary SQL execution by any authenticated user with read access to a SQL View: - GHSA-pwmg-mvjw-4m23 — error-based exfil via CAST((subquery) AS int) - internal report — UNION SELECT smuggled through the column-name slot Wrapping the column name with statementBuilder.columnQuote() turns the whole user-supplied string into a single Postgres identifier, which Postgres rejects at parse time when it doesn't exist — preventing the inner SQL from being evaluated. This is exactly the defense already in place for the parallel sink in getCriteriaSqlClause. Note: the master/2.40-2.42 backports use SqlUtils.quote() and ship companion regression tests in SqlViewControllerIntegrationTest. On 2.39 the matching defense API is statementBuilder.columnQuote() and the regression test class does not exist, so only the fix is applied. AI Assisted Refs GHSA-pwmg-mvjw-4m23, DHIS2-21425
|
jbee
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes backported to
2.39for the coordinated release.All commits GPG-signed; cherry-picked from the embargoed fixes and dry-run-verified clean against this branch. For the security release.
AI Assisted