Skip to content

test: Add regression test for externalAuth PUT round-trip [DHIS2-17597] #24336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karolinelien wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: Add regression test for externalAuth PUT round-trip [DHIS2-17597] #24336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b48c38
test: Add regression test for externalAuth PUT round-trip [DHIS2-17597]
karolinelien Jul 1, 2026
3f7be37
Merge branch 'master' into test/externalauth-put-roundtrip-DHIS2-17597
karolinelien Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ...2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/UserControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,31 @@ void testPutJsonObject() {
PUT("/38/users/" + peter.getUid(), user.toString()).content(HttpStatus.OK));
}

@Test
@DisplayName("externalAuth is preserved across repeated full GET/PUT round-trips (DHIS2-17597)")
void testPutJsonObjectPreservesExternalAuth() {
// given a user that authenticates externally (e.g. OIDC/LDAP)
User user = userService.getUser(peter.getUid());
user.setExternalAuth(true);
userService.updateUser(user);

// when the full representation is fetched and PUT back unchanged
JsonObject body = GET("/users/{id}", peter.getUid()).content();
assertTrue(
body.getBoolean("externalAuth").booleanValue(),
"precondition: fetched payload should carry externalAuth=true");
assertStatus(HttpStatus.OK, PUT("/users/" + peter.getUid(), body.toString()));
assertTrue(
userService.getUser(peter.getUid()).isExternalAuth(),
"externalAuth must remain true after the first round-trip PUT");

// and again with the identical payload: guards against the reported true<->false toggle
assertStatus(HttpStatus.OK, PUT("/users/" + peter.getUid(), body.toString()));
assertTrue(
userService.getUser(peter.getUid()).isExternalAuth(),
"externalAuth must remain true after a second identical PUT (no toggle)");
}

@Test
void testPutJsonObject_AddUserGroupLastUpdatedByUpdated() throws JsonProcessingException {
// create user
Expand Down
Loading