test: assert optionSet on stage-scoped data element headers [DHIS2-21344]#24395
Open
jason-p-pickering wants to merge 3 commits into
Open
test: assert optionSet on stage-scoped data element headers [DHIS2-21344]#24395jason-p-pickering wants to merge 3 commits into
jason-p-pickering wants to merge 3 commits into
Conversation
…344] EventsAggregate5AutoTest already exercised Zj7UnCAulEk.fWIAEtYVEGk (Mode of Discharge, an optionSet-backed data element in a program stage) but asserted the header via the validateHeader overload that skips optionSet, so the DataElement.optionSet mapping regression fixed by #23092's cherry-pick would not have been caught by CI.
jason-p-pickering
added
run-api-analytics-tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventsAggregate5AutoTestalready exercised an optionSet-backed, stage-scoped data element (Zj7UnCAulEk.fWIAEtYVEGk, Mode of Discharge) in two tests, but both asserted the header via theValidationHelper.validateHeaderoverload that skipsoptionSet, using the existing 8-arg overload instead of the 9-arg one that already asserts it.DataElement.optionSetgoing missing from/api/analytics/events/aggregateheaders — which is exactly what happened on the2.43maintenance line (see fix: backport DataElement.optionSet Hibernate mapping fix to 2.43 #24394) after12ebdf2d78("chore: annotation mapping for DataElement", chore: annotation mapping for DataElement #23092) fixed a latent Hibernate mapping bug on master but was never backported.12ebdf2d78), so this PR is test-coverage only — no production code change.Test plan
mvn compilepasses ondhis-test-e2e.🤖 Generated with Claude Code