fix: fall back to literal path on path-extension 406#24479
Merged
Conversation
After #24463, suffix-stripped lookup could match a JSON produces handler and throw HttpMediaTypeNotAcceptableException before the literal-suffix download mapping ran. Catch that 406 and retry the original path so analytics .xml/.csv/.xls/.xlsx downloads work again.
4 tasks
|
david-mackessy
approved these changes
Jul 17, 2026
jbee
approved these changes
Jul 20, 2026
2 tasks
jason-p-pickering
pushed a commit
that referenced
this pull request
Jul 23, 2026
Follow-up to #24479. Paths like /api/analytics.xlsx/ fully strip to /api/analytics, hit the JSON produces handler (406), then failed the literal fallback because the original URI still had the trailing slash and Spring 7 does not trailing-slash-match. Retry with only the trailing slash removed before the raw original path so literal download mappings still win. Covers the RestAssured basePath pattern used by AnalyticsAggregateDownloadTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
produceshandler and a literal-suffix download path (e.g./query/{id}.xml) started returning 406 after PR-F.application/xmlvia the suffix strategy, throwsHttpMediaTypeNotAcceptableException, and never falls back to the literal mapping.Why this surfaced now
Jason's Doris analytics PR #24440 CI failed on master HEAD with 12 e2e download tests (xml/csv/xls/xlsx). Not caused by that PR — master regression from #24463.
Test plan
CustomRequestMappingHandlerMappingNormalizeTest(13 tests, including new regression for analytics-style dual mappings)Notes