Skip to content

fix: correct off-by-one header/row assertions in ENROLLMENT_OU e2e test (2.43) #24506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jason-p-pickering merged 1 commit into from
Jul 20, 2026
+6 −3
Merged

fix: correct off-by-one header/row assertions in ENROLLMENT_OU e2e test (2.43) #24506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...-test-e2e/src/test/java/org/hisp/dhis/analytics/trackedentity/TrackedEntityQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,13 +1478,13 @@ public void queryWithProgramAndFilterByEnrollmentOuKeyword() {
response
.validate()
.statusCode(200)
.body("headers", hasSize(equalTo(16)))
.body("headers", hasSize(equalTo(17)))
.body("rows", hasSize(equalTo(14)))
.body("metaData.dimensions.ou", hasSize(equalTo(1)))
.body("metaData.dimensions.ou", hasItem("BV4IomHvri4"))
.body("height", equalTo(14))
.body("width", equalTo(16))
.body("headerWidth", equalTo(16));
.body("width", equalTo(17))
.body("headerWidth", equalTo(17));

// Validate the first three rows, as samples (identical to the `ou` variant).
validateRow(
Expand All @@ -1499,6 +1499,7 @@ public void queryWithProgramAndFilterByEnrollmentOuKeyword() {
"",
"",
"",
"",
"Ahmadiyya Muslim Hospital",
"OU_268246",
"Sierra Leone / Tonkolili / Yoni / Ahmadiyya Muslim Hospital",
Expand All @@ -1520,6 +1521,7 @@ public void queryWithProgramAndFilterByEnrollmentOuKeyword() {
"",
"",
"",
"",
"Ahmadiyya Muslim Hospital",
"OU_268246",
"Sierra Leone / Tonkolili / Yoni / Ahmadiyya Muslim Hospital",
Expand All @@ -1541,6 +1543,7 @@ public void queryWithProgramAndFilterByEnrollmentOuKeyword() {
"",
"",
"",
"",
"Ahmadiyya Muslim Hospital",
"OU_268246",
"Sierra Leone / Tonkolili / Yoni / Ahmadiyya Muslim Hospital",
Expand Down
Loading