fix: always pass outputIdScheme in download requests (DHIS2-20675)#312
Open
edoardo wants to merge 2 commits into
Open
fix: always pass outputIdScheme in download requests (DHIS2-20675)#312edoardo wants to merge 2 commits into
edoardo wants to merge 2 commits into
Conversation
|
🚀 Deployed on https://pr-312.event-visualizer.netlify.dhis2.org |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-20675
Description
The
outputIdSchemewas not always passed in the download analytics request, resulting in the returned data not respecting theidSchemebut always returning the uid.Fixed by always passing
outputIdSchemewith the desiredidScheme.Quality checklist
Add N/A to items that are not applicable and check them.
Screenshots
Before when downloading CSV with
NAMEidScheme, the uid was returned:After when downloading CSV with
NAMEidScheme, the resolved metadata name is returned: