fix(io): use a context manager in _lesson_already_appended#2
Open
diazMelgarejo wants to merge 1 commit into
Open
fix(io): use a context manager in _lesson_already_appended#2diazMelgarejo wants to merge 1 commit into
diazMelgarejo wants to merge 1 commit into
Conversation
The read-only probe opened lessons.jsonl with a bare open() and relied on GC to close the handle. Wrap it in a with-statement (and add explicit encoding="utf-8" for cross-platform consistency) so the file descriptor is released deterministically. Behavior is otherwise unchanged. Found and applied downstream in Perpetua-Tools; contributing back. Stacked on top of atomic-02 (UTF-8 fixes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atomic PR 03 of 3
Summary
The read-only probe in
_lesson_already_appendedopenedlessons.jsonlwith a bareopen()and relied on GC to close the handle. Wraps it in awithstatement (plus explicitencoding="utf-8"for cross-platform consistency) so the file descriptor is released deterministically. Behavior is otherwise unchanged.Verification
Applied cleanly on top of #2, syntax-checked, full stack's tests still pass (3/3). Found and applied downstream in Perpetua-Tools; contributing back.
Stack
3 of 3 in a small related set — based on #2 (which is based on #1).
See #1's description for the full context.