[WIP] Enable automatic detecting and loading all filter/sketch types#1717
Open
standage wants to merge 2 commits into
Open
[WIP] Enable automatic detecting and loading all filter/sketch types#1717standage wants to merge 2 commits into
standage wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 91 91
Lines 11483 11483
Branches 3056 3056
======================================
Hits 6 6
Misses 11477 11477
Continue to review full report at Codecov.
|
Member
Author
|
It looks like we either need to store a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1716.
So far this PR replaces the ad hoc
ht_typedefines with an enumerated type, and adds values for the *table types. Now the question is how to distinguish between *graph and *table types in the storage class, which by design is agnostic to this.make testDid it pass the tests?make clean diff-coverIf it introduces new functionality inscripts/is it tested?make format diff_pylint_report cppcheck doc pydocstyleIs it wellformatted?
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
documented in
CHANGELOG.md? See keepachangelogfor more details.
changes were made?
tested for streaming IO?)