Conversation
ctb
reviewed
Aug 9, 2025
| for k in get_close_matches(ident, taxdb): | ||
| print(f"* '{k}'") | ||
| sys.exit(-1) | ||
| if not getattr(args, "skip_missing_lineages", False): |
Member
There was a problem hiding this comment.
Here you could if not args.skip_missing_lineages - no need to use getattr, since with argparse it will always create the attribute on the args object.
Suggest printing something out for continuing vs failing (i.e. "continuing past error because --skip-missing-lineages is set" or "error exiting!"). Helps people debug!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #25
This pull request introduces a
skip-missing-lineagesargument to the CLI for the user to force the creation of the pangenome rank database.However, the first step a user should try is checking that the taxonomy file is current and updating the taxonomy files that are used to create the pangenomic databases.