Make timeouts affect metrics performance#304
Open
nck-mlcnv wants to merge 19 commits into
Open
Conversation
nkaralis
requested changes
Sep 3, 2025
nkaralis
requested changes
Sep 19, 2025
nkaralis
left a comment
nkaralis
left a comment
There was a problem hiding this comment.
Penalty needs to be applied for all timed out and failed queries (e.g., error code).
nkaralis
requested changes
Oct 1, 2025
nkaralis
left a comment
nkaralis
left a comment
There was a problem hiding this comment.
Also, please define timeouts and penalties in the readme.
nkaralis
reviewed
Oct 1, 2025
nkaralis
requested changes
Oct 26, 2025
nkaralis
left a comment
nkaralis
left a comment
There was a problem hiding this comment.
Please write test cases for the new metrics
nck-mlcnv
force-pushed
the
feature/metric-calculations
branch
from
2f5c0e7 to
af9e091
Compare
nkaralis
reviewed
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AvgQPS and QMPH metric should take in timeouts in their result.