Do not handle 5xx or 4xx responses in RestTemplate for the StatusUpdater as error

fixes #105

Author: Johannes Stelzer

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/config/AdminServerWebConfiguration.java

@@ -26,10 +26,12 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Import;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.converter.HttpMessageConverter;
 import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder;
 import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
 import org.springframework.scheduling.config.ScheduledTaskRegistrar;
+import org.springframework.web.client.DefaultResponseErrorHandler;
 import org.springframework.web.client.RestTemplate;
 import org.springframework.web.servlet.config.annotation.WebMvcConfigurerAdapter;
 
@@ -114,8 +116,13 @@ public ApplicationIdGenerator applicationIdGenerator() {
 	@ConfigurationProperties("spring.boot.admin.monitor")
 	public StatusUpdater statusUpdater(ApplicationStore store) {
 		RestTemplate template = new RestTemplate();
-		template.getMessageConverters().add(
-				new MappingJackson2HttpMessageConverter());
+		template.getMessageConverters().add(new MappingJackson2HttpMessageConverter());
+		template.setErrorHandler(new DefaultResponseErrorHandler() {
+			@Override
+			protected boolean hasError(HttpStatus statusCode) {
+				return false;
+			}
+		});
 		return new StatusUpdater(template, store);
 	}
 

spring-boot-admin-server/src/test/java/de/codecentric/boot/admin/registry/StatusUpdaterTest.java

@@ -84,7 +84,7 @@ public void test_update_noBody() {
 
 		// HTTP != 200 - DOWN
 		when(template.getForEntity("health", Map.class)).thenReturn(
-				ResponseEntity.status(500).<Map> body(null));
+				ResponseEntity.status(503).<Map> body(null));
 
 		updater.updateStatus(Application.create("foo").withId("id")
 				.withHealthUrl("health").build());