Clarify Modifier doc for name and default value#397
Open
daanzu wants to merge 1 commit into
Open
Conversation
drmfinlay
reviewed
Sep 3, 2025
Member
drmfinlay
left a comment
There was a problem hiding this comment.
Thanks, I hadn't noticed this.
Thinking about it, Modifier should probably have always had an optional name parameter like the rest of the element classes.
Collaborator
Author
|
I guess it could be handy sometimes to set a name, but it's awfully convenient to let it just take over its child's name. |
Member
|
Yes, the handy default behaviour should stay. Ditto for the value of |
Collaborator
Author
|
Upon reflection, adding a name parameter would also be good for avoiding resulting in an error if someone passes name out of habit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.