Fix inclusive integer max regressions#402
Open
kendonB wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Added a follow-up commit to fix a Problem: Fix:
I pushed this as commit Checked this one and it looks to be consistent with the idea of the original PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up fixes the regressions introduced by making
Integer-familymaxbounds inclusive in #395.Summary:
Integer,IntegerRef, andShortIntegerRefusing inclusive publicmaxboundsmaxvalue onIntegerwhile still passing an exclusive upper bound to the internal buildersNumberseries chunks back to0..99/1..99so the series form does not start accepting100after the inclusive change2000..20991..311..99days1..12, minutes0..5900..23, minutes0..59Integer(min=1, max=2)including the upper boundNumberrejecting three-digit series chunksValidation:
assisted by codex gpt5.4 xhigh