Skip to content

Commit 4f5f5cc

Browse files
committed
Remove redundant isolate uses
1 parent a445d0d commit 4f5f5cc

2 files changed

Lines changed: 4 additions & 12 deletions

File tree

example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ android {
4747
applicationId "com.islamdidarmd.example.adblockerwebview.flutter.example"
4848
// You can update the following values to match your application needs.
4949
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.
50-
minSdkVersion 19
50+
minSdkVersion flutter.minSdkVersion
5151
targetSdkVersion flutter.targetSdkVersion
5252
versionCode flutterVersionCode.toInteger()
5353
versionName flutterVersionName

lib/src/data/repository/adblocker_repository_impl.dart

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import 'dart:convert';
2-
import 'dart:isolate';
32

43
import 'package:adblocker_webview/src/domain/entity/host.dart';
54
import 'package:adblocker_webview/src/domain/repository/adblocker_repository.dart';
65
import 'package:flutter/foundation.dart';
7-
import 'package:flutter/services.dart';
86
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
97

108
class AdBlockerRepositoryImpl implements AdBlockerRepository {
@@ -29,14 +27,8 @@ class AdBlockerRepositoryImpl implements AdBlockerRepository {
2927
}
3028

3129
Future<String> _getDataWithCache(String url) async {
32-
final isolateToken = ServicesBinding.rootIsolateToken!;
33-
return Isolate.run(
34-
() async {
35-
BackgroundIsolateBinaryMessenger.ensureInitialized(isolateToken);
36-
final cacheManager = DefaultCacheManager();
37-
final file = await cacheManager.getSingleFile(url);
38-
return file.readAsString();
39-
},
40-
);
30+
final cacheManager = DefaultCacheManager();
31+
final file = await cacheManager.getSingleFile(url);
32+
return file.readAsString();
4133
}
4234
}

0 commit comments

Comments
 (0)