Skip to content

Commit b650496

Browse files
author
Didier Franc
committed
Move to prop-types to avoid alert with React > 15.4
1 parent 3b0b67a commit b650496

File tree

4 files changed

+101
-33
lines changed

4 files changed

+101
-33
lines changed

dist/react-code-splitting.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ var _react = require('react');
88

99
var _react2 = _interopRequireDefault(_react);
1010

11+
var _propTypes = require('prop-types');
12+
13+
var _propTypes2 = _interopRequireDefault(_propTypes);
14+
1115
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
1216

1317
function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
@@ -49,5 +53,5 @@ exports.default = Async;
4953

5054

5155
Async.propTypes = {
52-
load: _react2.default.PropTypes.instanceOf(Promise).isRequired
56+
load: _propTypes2.default.instanceOf(Promise).isRequired
5357
};

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-code-splitting",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"description": "Code splitting won't be a nightmare anymore",
55
"main": "./dist/react-code-splitting.js",
66
"repository": "https://github.com/didierfranc/react-code-splitting",
@@ -15,5 +15,8 @@
1515
"babel-preset-es2015": "^6.22.0",
1616
"babel-preset-react": "^6.22.0",
1717
"babel-preset-stage-0": "^6.22.0"
18+
},
19+
"dependencies": {
20+
"prop-types": "^15.5.8"
1821
}
1922
}

src/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from 'react'
2+
import PropTypes from 'prop-types'
23

34
export default class Async extends React.Component {
45
componentWillMount = () => {
@@ -12,5 +13,5 @@ export default class Async extends React.Component {
1213
}
1314

1415
Async.propTypes = {
15-
load: React.PropTypes.instanceOf(Promise).isRequired,
16+
load: PropTypes.instanceOf(Promise).isRequired,
1617
}

yarn.lock

Lines changed: 90 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ arrify@^1.0.0:
5050
version "1.0.1"
5151
resolved "https://registry.yarnpkg.com/arrify/-/arrify-1.0.1.tgz#898508da2226f380df904728456849c1501a4b0d"
5252

53+
asap@~2.0.3:
54+
version "2.0.5"
55+
resolved "https://registry.yarnpkg.com/asap/-/asap-2.0.5.tgz#522765b50c3510490e52d7dcfe085ef9ba96958f"
56+
5357
asn1@~0.2.3:
5458
version "0.2.3"
5559
resolved "https://registry.yarnpkg.com/asn1/-/asn1-0.2.3.tgz#dac8787713c9966849fc8180777ebe9c1ddf3b86"
@@ -107,7 +111,7 @@ babel-code-frame@^6.22.0:
107111
esutils "^2.0.2"
108112
js-tokens "^3.0.0"
109113

110-
babel-core@^6.22.0, babel-core@^6.22.1:
114+
babel-core@^6.22.1:
111115
version "6.22.1"
112116
resolved "https://registry.yarnpkg.com/babel-core/-/babel-core-6.22.1.tgz#9c5fd658ba1772d28d721f6d25d968fc7ae21648"
113117
dependencies:
@@ -767,19 +771,7 @@ babel-preset-stage-3@^6.22.0:
767771
babel-plugin-transform-exponentiation-operator "^6.22.0"
768772
babel-plugin-transform-object-rest-spread "^6.22.0"
769773

770-
babel-register@^6.22.0:
771-
version "6.22.0"
772-
resolved "https://registry.yarnpkg.com/babel-register/-/babel-register-6.22.0.tgz#a61dd83975f9ca4a9e7d6eff3059494cd5ea4c63"
773-
dependencies:
774-
babel-core "^6.22.0"
775-
babel-runtime "^6.22.0"
776-
core-js "^2.4.0"
777-
home-or-tmp "^2.0.0"
778-
lodash "^4.2.0"
779-
mkdirp "^0.5.1"
780-
source-map-support "^0.4.2"
781-
782-
babel-register@^6.23.0:
774+
babel-register@^6.22.0, babel-register@^6.23.0:
783775
version "6.23.0"
784776
resolved "https://registry.yarnpkg.com/babel-register/-/babel-register-6.23.0.tgz#c9aa3d4cca94b51da34826c4a0f9e08145d74ff3"
785777
dependencies:
@@ -818,46 +810,46 @@ babel-template@^6.23.0:
818810
babylon "^6.11.0"
819811
lodash "^4.2.0"
820812

821-
babel-traverse@^6.22.0, babel-traverse@^6.22.1:
822-
version "6.22.1"
823-
resolved "https://registry.yarnpkg.com/babel-traverse/-/babel-traverse-6.22.1.tgz#3b95cd6b7427d6f1f757704908f2fc9748a5f59f"
813+
babel-traverse@^6.22.0, babel-traverse@^6.23.0, babel-traverse@^6.23.1:
814+
version "6.23.1"
815+
resolved "https://registry.yarnpkg.com/babel-traverse/-/babel-traverse-6.23.1.tgz#d3cb59010ecd06a97d81310065f966b699e14f48"
824816
dependencies:
825817
babel-code-frame "^6.22.0"
826-
babel-messages "^6.22.0"
818+
babel-messages "^6.23.0"
827819
babel-runtime "^6.22.0"
828-
babel-types "^6.22.0"
820+
babel-types "^6.23.0"
829821
babylon "^6.15.0"
830822
debug "^2.2.0"
831823
globals "^9.0.0"
832824
invariant "^2.2.0"
833825
lodash "^4.2.0"
834826

835-
babel-traverse@^6.23.0, babel-traverse@^6.23.1:
836-
version "6.23.1"
837-
resolved "https://registry.yarnpkg.com/babel-traverse/-/babel-traverse-6.23.1.tgz#d3cb59010ecd06a97d81310065f966b699e14f48"
827+
babel-traverse@^6.22.1:
828+
version "6.22.1"
829+
resolved "https://registry.yarnpkg.com/babel-traverse/-/babel-traverse-6.22.1.tgz#3b95cd6b7427d6f1f757704908f2fc9748a5f59f"
838830
dependencies:
839831
babel-code-frame "^6.22.0"
840-
babel-messages "^6.23.0"
832+
babel-messages "^6.22.0"
841833
babel-runtime "^6.22.0"
842-
babel-types "^6.23.0"
834+
babel-types "^6.22.0"
843835
babylon "^6.15.0"
844836
debug "^2.2.0"
845837
globals "^9.0.0"
846838
invariant "^2.2.0"
847839
lodash "^4.2.0"
848840

849-
babel-types@^6.19.0, babel-types@^6.22.0:
850-
version "6.22.0"
851-
resolved "https://registry.yarnpkg.com/babel-types/-/babel-types-6.22.0.tgz#2a447e8d0ea25d2512409e4175479fd78cc8b1db"
841+
babel-types@^6.19.0, babel-types@^6.23.0:
842+
version "6.23.0"
843+
resolved "https://registry.yarnpkg.com/babel-types/-/babel-types-6.23.0.tgz#bb17179d7538bad38cd0c9e115d340f77e7e9acf"
852844
dependencies:
853845
babel-runtime "^6.22.0"
854846
esutils "^2.0.2"
855847
lodash "^4.2.0"
856848
to-fast-properties "^1.0.1"
857849

858-
babel-types@^6.23.0:
859-
version "6.23.0"
860-
resolved "https://registry.yarnpkg.com/babel-types/-/babel-types-6.23.0.tgz#bb17179d7538bad38cd0c9e115d340f77e7e9acf"
850+
babel-types@^6.22.0:
851+
version "6.22.0"
852+
resolved "https://registry.yarnpkg.com/babel-types/-/babel-types-6.22.0.tgz#2a447e8d0ea25d2512409e4175479fd78cc8b1db"
861853
dependencies:
862854
babel-runtime "^6.22.0"
863855
esutils "^2.0.2"
@@ -970,6 +962,10 @@ convert-source-map@^1.1.0:
970962
version "1.3.0"
971963
resolved "https://registry.yarnpkg.com/convert-source-map/-/convert-source-map-1.3.0.tgz#e9f3e9c6e2728efc2676696a70eb382f73106a67"
972964

965+
core-js@^1.0.0:
966+
version "1.2.7"
967+
resolved "https://registry.yarnpkg.com/core-js/-/core-js-1.2.7.tgz#652294c14651db28fa93bd2d5ff2983a4f08c636"
968+
973969
core-js@^2.4.0:
974970
version "2.4.1"
975971
resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.4.1.tgz#4de911e667b0eae9124e34254b53aea6fc618d3e"
@@ -1026,6 +1022,12 @@ ecc-jsbn@~0.1.1:
10261022
dependencies:
10271023
jsbn "~0.1.0"
10281024

1025+
encoding@^0.1.11:
1026+
version "0.1.12"
1027+
resolved "https://registry.yarnpkg.com/encoding/-/encoding-0.1.12.tgz#538b66f3ee62cd1ab51ec323829d1f9480c74beb"
1028+
dependencies:
1029+
iconv-lite "~0.4.13"
1030+
10291031
escape-string-regexp@^1.0.2:
10301032
version "1.0.5"
10311033
resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz#1b61c0562190a8dff6ae3bb2cf0200ca130b86d4"
@@ -1060,6 +1062,18 @@ extsprintf@1.0.2:
10601062
version "1.0.2"
10611063
resolved "https://registry.yarnpkg.com/extsprintf/-/extsprintf-1.0.2.tgz#e1080e0658e300b06294990cc70e1502235fd550"
10621064

1065+
fbjs@^0.8.9:
1066+
version "0.8.12"
1067+
resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.12.tgz#10b5d92f76d45575fd63a217d4ea02bea2f8ed04"
1068+
dependencies:
1069+
core-js "^1.0.0"
1070+
isomorphic-fetch "^2.1.1"
1071+
loose-envify "^1.0.0"
1072+
object-assign "^4.1.0"
1073+
promise "^7.1.1"
1074+
setimmediate "^1.0.5"
1075+
ua-parser-js "^0.7.9"
1076+
10631077
filename-regex@^2.0.0:
10641078
version "2.0.0"
10651079
resolved "https://registry.yarnpkg.com/filename-regex/-/filename-regex-2.0.0.tgz#996e3e80479b98b9897f15a8a58b3d084e926775"
@@ -1240,6 +1254,10 @@ http-signature@~1.1.0:
12401254
jsprim "^1.2.2"
12411255
sshpk "^1.7.0"
12421256

1257+
iconv-lite@~0.4.13:
1258+
version "0.4.15"
1259+
resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.15.tgz#fe265a218ac6a57cfe854927e9d04c19825eddeb"
1260+
12431261
inflight@^1.0.4:
12441262
version "1.0.6"
12451263
resolved "https://registry.yarnpkg.com/inflight/-/inflight-1.0.6.tgz#49bd6331d7d02d0c09bc910a1075ba8165b56df9"
@@ -1334,6 +1352,10 @@ is-property@^1.0.0:
13341352
version "1.0.2"
13351353
resolved "https://registry.yarnpkg.com/is-property/-/is-property-1.0.2.tgz#57fe1c4e48474edd65b09911f26b1cd4095dda84"
13361354

1355+
is-stream@^1.0.1:
1356+
version "1.1.0"
1357+
resolved "https://registry.yarnpkg.com/is-stream/-/is-stream-1.1.0.tgz#12d4a3dd4e68e0b79ceb8dbc84173ae80d91ca44"
1358+
13371359
is-typedarray@~1.0.0:
13381360
version "1.0.0"
13391361
resolved "https://registry.yarnpkg.com/is-typedarray/-/is-typedarray-1.0.0.tgz#e479c80858df0c1b11ddda6940f96011fcda4a9a"
@@ -1348,6 +1370,13 @@ isobject@^2.0.0:
13481370
dependencies:
13491371
isarray "1.0.0"
13501372

1373+
isomorphic-fetch@^2.1.1:
1374+
version "2.2.1"
1375+
resolved "https://registry.yarnpkg.com/isomorphic-fetch/-/isomorphic-fetch-2.2.1.tgz#611ae1acf14f5e81f729507472819fe9733558a9"
1376+
dependencies:
1377+
node-fetch "^1.0.1"
1378+
whatwg-fetch ">=0.10.0"
1379+
13511380
isstream@~0.1.2:
13521381
version "0.1.2"
13531382
resolved "https://registry.yarnpkg.com/isstream/-/isstream-0.1.2.tgz#47e63f7af55afa6f92e1500e690eb8b8529c099a"
@@ -1474,6 +1503,13 @@ nan@^2.3.0:
14741503
version "2.5.1"
14751504
resolved "https://registry.yarnpkg.com/nan/-/nan-2.5.1.tgz#d5b01691253326a97a2bbee9e61c55d8d60351e2"
14761505

1506+
node-fetch@^1.0.1:
1507+
version "1.6.3"
1508+
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-1.6.3.tgz#dc234edd6489982d58e8f0db4f695029abcd8c04"
1509+
dependencies:
1510+
encoding "^0.1.11"
1511+
is-stream "^1.0.1"
1512+
14771513
node-pre-gyp@^0.6.29:
14781514
version "0.6.33"
14791515
resolved "https://registry.yarnpkg.com/node-pre-gyp/-/node-pre-gyp-0.6.33.tgz#640ac55198f6a925972e0c16c4ac26a034d5ecc9"
@@ -1589,6 +1625,18 @@ process-nextick-args@~1.0.6:
15891625
version "1.0.7"
15901626
resolved "https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-1.0.7.tgz#150e20b756590ad3f91093f25a4f2ad8bff30ba3"
15911627

1628+
promise@^7.1.1:
1629+
version "7.1.1"
1630+
resolved "https://registry.yarnpkg.com/promise/-/promise-7.1.1.tgz#489654c692616b8aa55b0724fa809bb7db49c5bf"
1631+
dependencies:
1632+
asap "~2.0.3"
1633+
1634+
prop-types@^15.5.8:
1635+
version "15.5.8"
1636+
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.5.8.tgz#6b7b2e141083be38c8595aa51fc55775c7199394"
1637+
dependencies:
1638+
fbjs "^0.8.9"
1639+
15921640
punycode@^1.4.1:
15931641
version "1.4.1"
15941642
resolved "https://registry.yarnpkg.com/punycode/-/punycode-1.4.1.tgz#c0d5a63b2718800ad8e1eb0fa5269c84dd41845e"
@@ -1744,6 +1792,10 @@ set-immediate-shim@^1.0.1:
17441792
version "1.0.1"
17451793
resolved "https://registry.yarnpkg.com/set-immediate-shim/-/set-immediate-shim-1.0.1.tgz#4b2b1b27eb808a9f8dcc481a58e5e56f599f3f61"
17461794

1795+
setimmediate@^1.0.5:
1796+
version "1.0.5"
1797+
resolved "https://registry.yarnpkg.com/setimmediate/-/setimmediate-1.0.5.tgz#290cbb232e306942d7d7ea9b83732ab7856f8285"
1798+
17471799
signal-exit@^3.0.0:
17481800
version "3.0.2"
17491801
resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.2.tgz#b5fdc08f1287ea1178628e415e25132b73646c6d"
@@ -1856,6 +1908,10 @@ tweetnacl@^0.14.3, tweetnacl@~0.14.0:
18561908
version "0.14.5"
18571909
resolved "https://registry.yarnpkg.com/tweetnacl/-/tweetnacl-0.14.5.tgz#5ae68177f192d4456269d108afa93ff8743f4f64"
18581910

1911+
ua-parser-js@^0.7.9:
1912+
version "0.7.12"
1913+
resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.12.tgz#04c81a99bdd5dc52263ea29d24c6bf8d4818a4bb"
1914+
18591915
uid-number@~0.0.6:
18601916
version "0.0.6"
18611917
resolved "https://registry.yarnpkg.com/uid-number/-/uid-number-0.0.6.tgz#0ea10e8035e8eb5b8e4449f06da1c730663baa81"
@@ -1884,6 +1940,10 @@ verror@1.3.6:
18841940
dependencies:
18851941
extsprintf "1.0.2"
18861942

1943+
whatwg-fetch@>=0.10.0:
1944+
version "2.0.3"
1945+
resolved "https://registry.yarnpkg.com/whatwg-fetch/-/whatwg-fetch-2.0.3.tgz#9c84ec2dcf68187ff00bc64e1274b442176e1c84"
1946+
18871947
wide-align@^1.1.0:
18881948
version "1.1.0"
18891949
resolved "https://registry.yarnpkg.com/wide-align/-/wide-align-1.1.0.tgz#40edde802a71fea1f070da3e62dcda2e7add96ad"

0 commit comments

Comments
 (0)