fix(textkit): fix glyphIndexAt regression

[exoego]

Adapt advanceWidthBetween to new glyphIndexAt semantics from #3358.
Fix glyphIndexAt regression from #3358.
advanceWidthBetween was missed, causing width=0 for characters at run boundaries when scriptItemizer splits CJK text by script (Han/Hiragana/ Katakana). This broke text wrapping for any multi-script text.

Found this regression while working on #3288

[changeset-bot]

🦋 Changeset detected

Latest commit: 1c48732

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@react-pdf/textkit	Minor
@react-pdf/layout	Patch
@react-pdf/render	Patch
@react-pdf/renderer	Patch
@react-pdf/math	Patch
next-14	Patch
next-15	Patch
@react-pdf/vite-example	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[diegomura]

The refactored glyphIndexAt uses reverse-loop search instead of direct array lookup, requiring callers to use end - 1 (as slice.ts was updated).

Good catch. Wonder if we should fix glyphIndexAt requiring to pass end - 1 instead. All methods here don't require that. Was not intentional

[exoego]

@diegomura Ah, ok. Fixed glyphIndexAt instead.

[ecrousseau]

I have (I think?) a similar issue - my issue is with rendering Arabic, but the bug seems to also be in glyphIndexAt and to be related to the backwards processing.

I get an error like

file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/textkit/lib/textkit.js:992
            if (addedGlyphs.has(glyph.id))
                                      ^

TypeError: Cannot read properties of undefined (reading 'id')
    at file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/textkit/lib/textkit.js:992:39
    at Array.map (<anonymous>)
    at reorderLine (file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/textkit/lib/textkit.js:984:35)
    at Array.map (<anonymous>)
    at reorderParagraph (file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/textkit/lib/textkit.js:1012:51)
    at Array.map (<anonymous>)
    at Array.<anonymous> (file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/textkit/lib/textkit.js:1023:39)
    at file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/textkit/node_modules/@react-pdf/fns/lib/index.js:67:24
    at file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/textkit/lib/textkit.js:1834:199
    at layoutText (file:///Users/edward.rousseau/src/clean/node_modules/@react-pdf/layout/lib/index.js:1677:19)

Node.js v22.9.0

Minimal example to reproduce:

import { renderToBuffer } from '@react-pdf/renderer';
import { Document, Page, Text, Font } from '@react-pdf/renderer';
import React from 'react';

Font.register({
  family: 'Noto Sans Arabic',
  src: 'https://cdn.jsdelivr.net/npm/@fontsource/noto-sans-arabic/files/noto-sans-arabic-arabic-400-normal.woff',
});

const doc = React.createElement(
  Document,
  null,
  React.createElement(
    Page,
    null,
    React.createElement(
      Text,
      { style: { fontFamily: 'Noto Sans Arabic', direction: 'rtl' } },
      'نائب وزير'
    )
  )
);

console.log('Rendering...');
renderToBuffer(doc);

I'm not sure if the change proposed here will fix my issue.

For anyone else with the same issue as me: downgrading to @react-pdf/textkit 6.1.1 works for now.