fix(pdfkit): declare pako browser dependency#3453
Open
afonsojramos wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 9a2f43f The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PDFKit browser build deliberately externalizes imports such as
pako/lib/zlib/zstream.js, but@react-pdf/pdfkitdoes not declarepakoas a runtime dependency. Strict package layouts therefore keeppakonested underbrowserify-zlib, and consumers fail to bundle the browser entry because the direct import cannot resolve.This reproduces with Vite 8/Rolldown under an isolated global-store layout.
Fix
Declare
pako@^1.0.11inpackages/pdfkit/package.jsonand add a patch changeset.Validation
corepack yarn workspace @react-pdf/pdfkit buildlib/pdfkit.jsandlib/pdfkit.browser.jsbuild successfully