fix(ci): re-green release/v3.8.43 fast-gates — db-rules stale allowlist + 4 more base-reds (#5798)#5896
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…fs, mutation-cov, ratchets) (#5798)
…aseExecutor (typecheck:core base-red, #5798)
|
Merge note — remaining unit-shard reds are pre-existing base-reds, not from this PR. All 20+ Fast Quality Gates steps + typecheck + dast-smoke (full
These came in via yesterday's admin-merged burst while the fast-gates queue was base-red (each earlier red masked the next — this PR unmasked and fixed 7 layers: db-rules, env-docs, fabricated-docs, mutation-cov, ratchets, typecheck:core, MDX frontmatter/build). The 6 unit base-reds are queued for a dedicated follow-up sweep (they need per-file root-cause diagnosis — a red test can be a masked production bug, not a stale test). Merging with admin to unblock the whole PR→release queue; #5798 stays open tracking the unit sweep. |
Clears the actionable HARD failures tracked in #5798 (does NOT close the tracker — the ar/CHANGELOG i18n body-size drift stays captain-owned at release). As of 2026-07-02 every
quality.ymlfast-gates run on PR→release was failing on inherited base-reds; this PR re-greens the queue.Base-reds cleared (all verified base-red on the pristine tip
0d3875a98first)check:db-rules— stale allowlist entry. fix(db): allowlist modelContextOverrides as intentionally-internal (#5798 release-green) #5827 allowlistedmodelContextOverridesas intentionally-internal while the Release v3.8.43 #5609 fix (66c5b718c) re-exported it fromlocalDb.ts; with the re-export in place the entry suppressed nothing and the stale-enforcement (Fase 6A.3) failed the gate. The re-export stays (documented convention, CLAUDE.md "Adding a New DB Module" step 4); the obsolete entry is removed andtests/unit/check-db-rules-classification.test.tsre-pinned to 33 modules (TDD: test updated first → failed → gate fixed → 5/5 + exit 0).check:docs-all(env/docs contract).LIVE_WS_ALLOWED_HOSTS+NEXT_PUBLIC_LIVE_WS_PUBLIC_URL(from feat: add NEXT_PUBLIC_LIVE_WS_PUBLIC_URL for custom domain WebSocket support #5877/feat: add NEXT_PUBLIC_LIVE_WS_PUBLIC_URL for custom domain WebSocket support #5878) were in.env.examplebut missing fromdocs/reference/ENVIRONMENT.md— documented both.check:fabricated-docs --strict. The Router Backends ADR (docs(architecture): Router Backends & Embedded Services ADR (#5603) #5891) referencessrc/domain/routing/routerBackends.tsandROUTER_BACKENDS, which land with the still-open PR [codex] Add router backend registry #5868 — the doc now marks them as landing-with-[codex] Add router backend registry #5868 and the registry constant is allowlisted with justification (established JS-identifier pattern).check:mutation-test-coverage.antigravity-429-quota-tdd.test.ts+middleware-header-strip-5849.test.tsadded to strykertap.testFiles(+2 lines).Validation
check:docs-all,check:db-rules,check:file-size,check:mutation-test-coverage,check:complexity,check:cognitive-complexity,check:deps,check:fetch-targets,check:docs-symbols,check:openapi-routes,check:known-symbols,check:build-scope,check:pack-policy,check:any-budget:t11,check:error-helper,check:migration-numbering,check:public-creds,check:route-guard-membership,check:test-discovery,check:test-runner-api→ all exit 0.tests/unit/check-db-rules-classification.test.ts→ 5/5.tests/unit/access-token-scopes.test.ts(6/6),tests/integration/all-statuses-route.test.ts(8/8).Update — 6th base-red unmasked and fixed
typecheck:core. Two TS2322 errors inopen-sse/executors/base.ts(from the refactor(executors): deduplicate shared utilities and add comprehensive tests #5720 dedup refactor), masked until now because the fast-gates chain failed earlier:resolveBaseUrlreturnedunknown-typedproviderSpecificData.baseUrl(nowtypeof === "string"coercion, same pattern asDefaultExecutor), andresolveEffectiveKeycould returnundefinedwhencredentials.apiKeywas absent (now?? ""— behavior-safe: both consumers gate on truthiness). Verified base-red: identical errors on the pristine tip. Validation:typecheck:coreexit 0;tests/unit/executor-base-utils.test.ts+executor-default-base.test.ts→ 71/71.