Commit d007ffb
docs(types): correct scrollbackLimit field documentation (#1)
scrollback_limit is passed to Ghostty's Terminal.max_scrollback, which is
in bytes. The low-level GhosttyTerminalConfig / TerminalConfig docs
described it as "number of scrollback lines", which is misleading — a
caller passing 10,000 expecting lines gets 10,000 bytes and falls below
the 2-page PageList floor.
Only the low-level docstrings are corrected here. The xterm.js-compat
ITerminalOptions.scrollback field still inherits xterm.js-compat framing
and a misleadingly xterm.js-shaped default (1000) despite plumbing
directly to a bytes-valued field; fixing that properly requires a
lines-to-bytes conversion and a separate PR.
Inspired-by: coder#151
Co-authored-by: Sauyon Lee <git@sjle.co>1 parent c3115f2 commit d007ffb
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
532 | 532 | | |
533 | 533 | | |
534 | 534 | | |
| 535 | + | |
535 | 536 | | |
536 | 537 | | |
537 | 538 | | |
| |||
604 | 605 | | |
605 | 606 | | |
606 | 607 | | |
607 | | - | |
| 608 | + | |
608 | 609 | | |
609 | 610 | | |
610 | 611 | | |
| |||
0 commit comments