Fix truncated text and vertically center done text#255
Fix truncated text and vertically center done text#255bbjay wants to merge 5 commits intodiegoveloper:masterfrom
Conversation
|
you can use |
not sure if I get what you mean with this comment. |
| child: Container( | ||
| padding: | ||
| EdgeInsets.symmetric(vertical: 8.0, horizontal: 12.0), | ||
| EdgeInsets.symmetric(vertical: 6.0, horizontal: 12.0), |
There was a problem hiding this comment.
I see, one fix that we can do is if the user specify a defaultDoneWidget, then this padding shouldn't be apply to that, so you are free to use your own padding.
What do you think?
There was a problem hiding this comment.
That would be even better, as it adds even more flexibility. I would keep the change of vertical padding from 8 to 6 though, otherwise users of the newly added defaultDoneButtonText will run into the same issue as in #254.
I will add a commit shortly.
|
yeah, can you update the samples please? |


Fixes #254
Before:

After:
