Skip to content

Fix truncated text and vertically center done text #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbjay wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix truncated text and vertically center done text #255

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b501aa7
vertically center done text
bbjay Nov 30, 2025
b476d16
Merge remote-tracking branch 'upstream/master'
bbjay Dec 1, 2025
a2b937d
Merge branch 'master' into done-text-truncation-fix
bbjay Dec 1, 2025
88c7d02
do not apply padding to custom defaultDoneWidget
bbjay Dec 1, 2025
a40b08a
adapt examples to new defaultDoneWidget layout
bbjay Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/keyboard_actions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ class KeyboardActionstate extends State<KeyboardActions>
},
child: Container(
padding:
EdgeInsets.symmetric(vertical: 8.0, horizontal: 12.0),
EdgeInsets.symmetric(vertical: 6.0, horizontal: 12.0),
Copy link
Copy Markdown
Owner

@diegoveloper diegoveloper Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, one fix that we can do is if the user specify a defaultDoneWidget, then this padding shouldn't be apply to that, so you are free to use your own padding.
What do you think?

Copy link
Copy Markdown
Contributor Author

@bbjay bbjay Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be even better, as it adds even more flexibility. I would keep the change of vertical padding from 8 to 6 though, otherwise users of the newly added defaultDoneButtonText will run into the same issue as in #254.
I will add a commit shortly.

child: config?.defaultDoneWidget ??
Text(
"Done",
Expand Down