Draft
Conversation
tautschnig
approved these changes
Mar 5, 2026
| import6.sv | ||
| --bound 0 | ||
| ^EXIT=2$ | ||
| ^EXIT=6$ |
Collaborator
There was a problem hiding this comment.
Here and below: can we also include a check for the presence of an error message?
| import8.sv | ||
| --bound 0 | ||
| ^EXIT=2$ | ||
| ^EXIT=6$ |
Collaborator
There was a problem hiding this comment.
Same here: test for the error message.
Per IEEE 1800-2017 section 26.3, this adds error detection for: - Direct imports that conflict with local declarations - Wildcard imports that are used in expressions and then redeclared Wildcard imports that are not used remain 'potentially locally visible' and can be shadowed by local declarations.
kroening
force-pushed
the
verilog-import-conflicts
branch
from
73a7ae7 to
78b2190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per IEEE 1800-2017 section 26.3, this adds error detection for:
Wildcard imports that are not used remain 'potentially locally visible' and can be shadowed by local declarations.