Merged
Conversation
This changes the identifier lookup to use the scope stack instead of the parent pointer chain. The ordering of the scopes used for Verilog identifier lookup does not necessarily match the parent child ordering. As an example, modules are in the "definition" or root scope, visible across compilation unit, but identifiers in the compilation unit scope in which the module is defined are nevertheless visible in the module.
d1578a0 to
ea15de7
Compare
tautschnig
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the identifier lookup to use the scope stack instead of the parent pointer chain.
The ordering of the scopes used for Verilog identifier lookup does not necessarily match the parent child ordering. As an example, modules are in the "definition" or root scope, visible across compilation unit, but identifiers in the compilation unit scope in which the module is defined are nevertheless visible in the module.