Conversation
tautschnig
reviewed
Apr 20, 2026
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
- Do all solvers that can be invoked support FPA?
- This change also makes expressions/cast_to_real3.desc pass.
Collaborator
Author
We don't really know. CVC3, CVC4 and YICES support should likely be removed, given that these solvers aren't maintained. BOOLECTOR doesn't support FPA. BITWUZLA and MATHSAT support it according to their webpages, but we haven't got that tested at all.
Yes, but we don't have a mechanism for "test works with SMT, but not with flattening solver". I'll first fix this in the flattening solver. |
Collaborator
Author
|
Now limited to Z3. Note that this is already the default when using Bitwutzla or CVC 5. |
This enables the use of the FPA theory when generating SMT-LIB2 for Z3. This is already the default when using Bitwutzla or CVC 5.
tautschnig
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the use of the FPA theory when generating SMT-LIB2.