SMV: error on FAIRNESS constraints#1996
Open
kroening wants to merge 1 commit into
Open
Conversation
EBMC does not support fairness constraints. Previously, FAIRNESS declarations were parsed and typechecked without error but silently ignored during model checking. This change rejects them at typecheck time with a clear error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EBMC does not support fairness constraints. Previously, FAIRNESS declarations were parsed and typechecked without error but silently ignored during model checking. This change rejects them at typecheck time with a clear error message.
Changes
src/smvlang/smv_typecheck.cpp: Replace the FAIRNESS typecheck logic with an error throwregression/smv/fairness/fairness1.{smv,desc}: Regression test confirming the errorTesting
make -C regression/smv test— all tests passmake -C regression/smv test-z3— all tests pass