Temporal logic: restrict LTL_to_CTL to common fragment#2003
Open
kroening wants to merge 2 commits into
Open
Conversation
Implement the LTLdet fragment from Maidl's common-fragment result instead of recursively rewriting arbitrary F and G. Keep supported BDD LTL cases such as Gp and GFp, reject unsupported formulas such as FGp and FXXp, and add direct unit coverage for LTL_to_CTL.
tautschnig
reviewed
Jul 13, 2026
| or_exprt{ | ||
| and_exprt{p, AX_exprt{q}}, | ||
| and_exprt{not_exprt{p}, r}}}); | ||
| or_exprt{and_exprt{p, AX_exprt{q}}, and_exprt{not_exprt{p}, r}}}); |
Collaborator
There was a problem hiding this comment.
Hmm, did clang-format changes get folded into this commit? I don't see a semantic difference in this line (similarly the case for others in this commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restrict LTL_to_CTL to the LTLdet fragment from Maidl's common-fragment result instead of recursively rewriting arbitrary F and G.
This keeps supported BDD LTL cases such as Gp and GFp, rejects unsupported formulas such as FGp and FXXp, and adds direct unit coverage for LTL_to_CTL.
Testing