Skip to content

Commit 64ff4e8

Browse files
nedtwiggclaude
andcommitted
Code review cleanups on tether branch
- Use text-xs instead of text-[11px] in MobileTerminalUi selector label - Use clsx instead of template-string concat for conditional classes in Wall - Tighten WallModule.Wall type in Tether.tsx (drop ComponentType<any>) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 4a3f6dd commit 64ff4e8

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

lib/src/components/MobileTerminalUi.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ function KeyboardModeButton({
181181

182182
function SelectorLabel({ children }: { children: ReactNode }) {
183183
return (
184-
<div className="w-[4.5rem] shrink-0 pl-2 pr-1 font-mono text-[11px] leading-none text-muted">
184+
<div className="w-[4.5rem] shrink-0 pl-2 pr-1 font-mono text-xs leading-none text-muted">
185185
{children}
186186
</div>
187187
);

lib/src/components/Wall.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { useRef, useState, useEffect, useCallback, useMemo, type ReactNode } from 'react';
2+
import { clsx } from 'clsx';
23
import {
34
DockviewReact,
45
themeAbyss,
@@ -594,8 +595,8 @@ export function Wall({
594595
<DialogKeyboardContext.Provider value={setDialogKeyboardActive}>
595596
<div className="flex-1 min-h-0 flex flex-col bg-app-bg text-app-fg font-sans overflow-hidden">
596597
{/* Dockview — 2px bottom inset keeps rounded panes distinct from the baseboard when present. */}
597-
<div className={`flex-1 min-h-0 relative px-1.5 pt-1.5 ${showBaseboard ? 'pb-0.5' : 'pb-1.5'}`}>
598-
<div ref={dockviewContainerRef} className={`absolute inset-x-1.5 top-1.5 ${showBaseboard ? 'bottom-0.5' : 'bottom-1.5'}`}>
598+
<div className={clsx('flex-1 min-h-0 relative px-1.5 pt-1.5', showBaseboard ? 'pb-0.5' : 'pb-1.5')}>
599+
<div ref={dockviewContainerRef} className={clsx('absolute inset-x-1.5 top-1.5', showBaseboard ? 'bottom-0.5' : 'bottom-1.5')}>
599600
<DockviewReact
600601
components={components}
601602
tabComponents={tabComponents}

website/src/pages/Tether.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useCallback, useEffect, useRef, useState, useSyncExternalStore, type ComponentType } from "react";
1+
import { useCallback, useEffect, useRef, useState, useSyncExternalStore } from "react";
22
import { ShareIcon } from "@phosphor-icons/react";
33
import SiteHeader, { STATIC_PAGE_HEADER_STYLE } from "../components/SiteHeader";
44
import { NotifySignupForm } from "../components/NotifySignupForm";
@@ -23,7 +23,7 @@ const TETHER_PANE = "tether-ascii-splash";
2323
const TETHER_THEME_ID = "vscode.theme-kimbie-dark.kimbie-dark";
2424

2525
interface WallModule {
26-
Wall: ComponentType<any>;
26+
Wall: typeof import("mouseterm-lib/components/Wall")["Wall"];
2727
}
2828

2929
interface DockviewApiLike {

0 commit comments

Comments
 (0)