Tidy split cwd handling: name PendingShellOpts, share test setup

- Extract `PendingShellOpts` interface in terminal-store so the
  `{ shell?; args?; cwd? }` shape stops being repeated across the
  store and the lifecycle module.
- Drop a stale narrative comment in Wall.tsx; tighten the remaining
  one to explain why remote cwds are skipped.
- Hoist the duplicated `vi.stubGlobal` setup in
  terminal-registry.alert.test.ts into shared
  install/uninstallRegistryTestGlobals helpers so the new
  pending-shell-opts describe block reuses the existing setup.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: nedtwigg

lib/src/components/Wall.tsx

@@ -611,8 +611,7 @@ export function Wall({
     const ref = id && api.getPanel(id) ? id : null;
     // Carry the currently-selected shell into the split, same as [+].
     const defaults = getDefaultShellOpts();
-    // Inherit the source pane's cwd when known and local (diffplug/mouseterm#4).
-    // Remote cwds (e.g. from OSC 7 over ssh) aren't usable as a local spawn cwd.
+    // Remote cwds (OSC 7 over ssh) name a path on the remote host, not one the local shell can chdir to.
     const sourceCwd = ref ? getTerminalPaneState(ref).cwd : null;
     const inheritedCwd = sourceCwd && !sourceCwd.isRemote ? sourceCwd.path : undefined;
     if (defaults?.shell || inheritedCwd) {

lib/src/lib/terminal-lifecycle.ts

@@ -12,6 +12,7 @@ import { extractSelectionText } from './selection-text';
 import {
   pendingShellOpts,
   registry,
+  type PendingShellOpts,
   type TerminalEntry,
   type TerminalOverlayDims,
 } from './terminal-store';
@@ -207,7 +208,7 @@ function setupTerminalEntry(id: string, options: { untouched?: boolean } = {}):
   return entry;
 }
 
-export function setPendingShellOpts(id: string, opts: { shell?: string; args?: string[]; cwd?: string }): void {
+export function setPendingShellOpts(id: string, opts: PendingShellOpts): void {
   pendingShellOpts.set(id, opts);
 }
 

lib/src/lib/terminal-registry.alert.test.ts

@@ -221,37 +221,40 @@ function driveToRingingNeedsAttention(id: string): void {
   expect(getActivity(id).status).toBe('ALERT_RINGING');
 }
 
-describe('terminal-registry alert behavior', () => {
-  beforeEach(() => {
-    vi.useFakeTimers();
-    fakePlatform.reset();
-    initAlertStateReceiver();
-
-    const documentElement = new MockElement();
-    vi.stubGlobal('document', {
-      createElement: () => new MockElement(),
-      documentElement,
-    });
-    vi.stubGlobal('getComputedStyle', () => ({
-      getPropertyValue: () => '#000000',
-    }));
-    vi.stubGlobal('requestAnimationFrame', (callback: FrameRequestCallback) => {
-      callback(0);
-      return 0;
-    });
-    vi.stubGlobal('MutationObserver', class { observe() {} disconnect() {} });
-    vi.stubGlobal('window', {
-      addEventListener: () => {},
-      removeEventListener: () => {},
-    });
+function installRegistryTestGlobals(): void {
+  vi.useFakeTimers();
+  fakePlatform.reset();
+  initAlertStateReceiver();
+
+  const documentElement = new MockElement();
+  vi.stubGlobal('document', {
+    createElement: () => new MockElement(),
+    documentElement,
+  });
+  vi.stubGlobal('getComputedStyle', () => ({
+    getPropertyValue: () => '#000000',
+  }));
+  vi.stubGlobal('requestAnimationFrame', (callback: FrameRequestCallback) => {
+    callback(0);
+    return 0;
+  });
+  vi.stubGlobal('MutationObserver', class { observe() {} disconnect() {} });
+  vi.stubGlobal('window', {
+    addEventListener: () => {},
+    removeEventListener: () => {},
   });
+}
 
-  afterEach(() => {
-    disposeAllSessions();
-    fakePlatform.reset();
-    vi.unstubAllGlobals();
-    vi.useRealTimers();
-  });
+function uninstallRegistryTestGlobals(): void {
+  disposeAllSessions();
+  fakePlatform.reset();
+  vi.unstubAllGlobals();
+  vi.useRealTimers();
+}
+
+describe('terminal-registry alert behavior', () => {
+  beforeEach(installRegistryTestGlobals);
+  afterEach(uninstallRegistryTestGlobals);
 
   it('starts brand-new sessions as untouched', () => {
     const id = 'new-untouched';
@@ -968,35 +971,13 @@ describe('pending shell opts → spawnPty', () => {
   let spawnSpy: ReturnType<typeof vi.spyOn>;
 
   beforeEach(() => {
-    vi.useFakeTimers();
-    fakePlatform.reset();
-    initAlertStateReceiver();
-    const documentElement = new MockElement();
-    vi.stubGlobal('document', {
-      createElement: () => new MockElement(),
-      documentElement,
-    });
-    vi.stubGlobal('getComputedStyle', () => ({
-      getPropertyValue: () => '#000000',
-    }));
-    vi.stubGlobal('requestAnimationFrame', (callback: FrameRequestCallback) => {
-      callback(0);
-      return 0;
-    });
-    vi.stubGlobal('MutationObserver', class { observe() {} disconnect() {} });
-    vi.stubGlobal('window', {
-      addEventListener: () => {},
-      removeEventListener: () => {},
-    });
+    installRegistryTestGlobals();
     spawnSpy = vi.spyOn(fakePlatform, 'spawnPty');
   });
 
   afterEach(() => {
-    disposeAllSessions();
-    fakePlatform.reset();
     spawnSpy.mockRestore();
-    vi.unstubAllGlobals();
-    vi.useRealTimers();
+    uninstallRegistryTestGlobals();
   });
 
   it('forwards a pending cwd to spawnPty (split inherits source pane cwd)', () => {

lib/src/lib/terminal-store.ts

@@ -36,8 +36,14 @@ export interface TerminalOverlayDims {
   gridTop: number;
 }
 
+export interface PendingShellOpts {
+  shell?: string;
+  args?: string[];
+  cwd?: string;
+}
+
 export const registry = new Map<string, TerminalEntry>();
-export const pendingShellOpts = new Map<string, { shell?: string; args?: string[]; cwd?: string }>();
+export const pendingShellOpts = new Map<string, PendingShellOpts>();
 
 export function getEntryByPtyId(ptyId: string): TerminalEntry | null {
   for (const entry of registry.values()) {