Skip to content

Commit ffcaa0d

Browse files
nedtwiggnedtwigg
committed
gh_new_pr -> gh_pr_new for consistency with the others.
1 parent bfd6f2a commit ffcaa0d

4 files changed

Lines changed: 51 additions & 51 deletions

File tree

‎tests/corpus/_corpus-index.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ export const CORPUS: Record<string, CorpusEntry> = {
2323
type: 'html',
2424
url: 'https://github.com/diffplug/gitcasso/issues/new',
2525
},
26-
gh_new_pr: {
27-
type: 'har',
28-
url: 'https://github.com/diffplug/selfie/compare/main...cavia-porcellus:selfie:main?expand=1',
29-
},
3026
gh_pr: {
3127
type: 'har',
3228
url: 'https://github.com/diffplug/selfie/pull/517',
@@ -36,6 +32,10 @@ export const CORPUS: Record<string, CorpusEntry> = {
3632
type: 'html',
3733
url: 'https://github.com/diffplug/gitcasso/pull/58',
3834
},
35+
gh_pr_new: {
36+
type: 'har',
37+
url: 'https://github.com/diffplug/selfie/compare/main...cavia-porcellus:selfie:main?expand=1',
38+
},
3939
gh_project: {
4040
description: 'github project board initial load',
4141
type: 'html',

tests/corpus/gh_new_pr.har renamed to tests/corpus/gh_pr_new.har

File renamed without changes.

‎tests/lib/enhancers/__snapshots__/gh_detection.test.ts.snap‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -54,27 +54,6 @@ exports[`github detection > gh_issue_new:should detect correct spots 1`] = `
5454
]
5555
`;
5656

57-
exports[`github detection > gh_new_pr:should detect correct spots 1`] = `
58-
[
59-
{
60-
"for": "id=feedback name=feedback className=form-control width-full mb-2",
61-
"spot": "NO_SPOT",
62-
},
63-
{
64-
"for": "id=pull_request_body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field CommentBox-input--large overtype-input",
65-
"spot": {
66-
"base": "main",
67-
"domain": "github.com",
68-
"head": "cavia-porcellus:selfie:main",
69-
"slug": "diffplug/selfie",
70-
"title": "Update README.md",
71-
"type": "GH_PR_NEW_COMMENT",
72-
"unique_key": "github.com:diffplug/selfie:main...cavia-porcellus:selfie:main",
73-
},
74-
},
75-
]
76-
`;
77-
7857
exports[`github detection > gh_pr:should detect correct spots 1`] = `
7958
[
8059
{
@@ -121,6 +100,27 @@ exports[`github detection > gh_pr_edit:should detect correct spots 1`] = `
121100
]
122101
`;
123102

103+
exports[`github detection > gh_pr_new:should detect correct spots 1`] = `
104+
[
105+
{
106+
"for": "id=feedback name=feedback className=form-control width-full mb-2",
107+
"spot": "NO_SPOT",
108+
},
109+
{
110+
"for": "id=pull_request_body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field CommentBox-input--large overtype-input",
111+
"spot": {
112+
"base": "main",
113+
"domain": "github.com",
114+
"head": "cavia-porcellus:selfie:main",
115+
"slug": "diffplug/selfie",
116+
"title": "Update README.md",
117+
"type": "GH_PR_NEW_COMMENT",
118+
"unique_key": "github.com:diffplug/selfie:main...cavia-porcellus:selfie:main",
119+
},
120+
},
121+
]
122+
`;
123+
124124
exports[`github detection > gh_project:should detect correct spots 1`] = `[]`;
125125

126126
exports[`github detection > gh_project_draft:should detect correct spots 1`] = `[]`;

‎tests/lib/enhancers/__snapshots__/gh_ui.test.ts.snap‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -80,32 +80,6 @@ exports[`github ui > gh_issue_new:should render correct UI elements 1`] = `
8080
]
8181
`;
8282

83-
exports[`github ui > gh_new_pr:should render correct UI elements 1`] = `
84-
[
85-
{
86-
"for": "id=feedback name=feedback className=form-control width-full mb-2",
87-
"title": null,
88-
"upperDecoration": null,
89-
},
90-
{
91-
"for": "id=pull_request_body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field CommentBox-input--large overtype-input",
92-
"title": "Update README.md",
93-
"upperDecoration": <React.Fragment>
94-
<span>
95-
New PR
96-
</span>
97-
<span
98-
className="font-mono text-muted-foreground text-sm"
99-
>
100-
101-
diffplug/selfie
102-
103-
</span>
104-
</React.Fragment>,
105-
},
106-
]
107-
`;
108-
10983
exports[`github ui > gh_pr:should render correct UI elements 1`] = `
11084
[
11185
{
@@ -165,6 +139,32 @@ exports[`github ui > gh_pr_edit:should render correct UI elements 1`] = `
165139
]
166140
`;
167141

142+
exports[`github ui > gh_pr_new:should render correct UI elements 1`] = `
143+
[
144+
{
145+
"for": "id=feedback name=feedback className=form-control width-full mb-2",
146+
"title": null,
147+
"upperDecoration": null,
148+
},
149+
{
150+
"for": "id=pull_request_body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field CommentBox-input--large overtype-input",
151+
"title": "Update README.md",
152+
"upperDecoration": <React.Fragment>
153+
<span>
154+
New PR
155+
</span>
156+
<span
157+
className="font-mono text-muted-foreground text-sm"
158+
>
159+
160+
diffplug/selfie
161+
162+
</span>
163+
</React.Fragment>,
164+
},
165+
]
166+
`;
167+
168168
exports[`github ui > gh_project:should render correct UI elements 1`] = `[]`;
169169

170170
exports[`github ui > gh_project_draft:should render correct UI elements 1`] = `[]`;

0 commit comments

Comments
 (0)